sql error upon install
moshe weitzman - February 3, 2008 - 02:51
| Project: | Block Assign |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
looks like a typo. i am using latest HEAD
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'VALUES("user", "uri", ".*", 1))' at line 1 query: block_assign_install INSERT INTO block_assign(module, condition_type, condition_value, box_id VALUES("user", "uri", ".*", 1)) in /Users/mw/htd/dr5/includes/database.mysqli.inc on line 151.
#1
may i also suggest thsat you run coder.module against your code and you will see many problems when compared to drupal standards compliance. this module has great potential, but also has a ways to go in terms of code polish. thanks for your efforts to date.
#2
Ugh, that's what I get for adding a simple change untested. I've fixed the typo. I've also followed your suggestion and run the coder module against the module and brought it up to snuff with Drupal standards. I also corrected an issue that would have caused problems upon module uninstall: The php code being stuck in the pages column of the blocks table wasn't testing for function_exists('block_assign_show') and so resulted in errors upon block uninstall. I've added a test there to keep from hosing people's sites.
#3
Automatically closed -- issue fixed for two weeks with no activity.