Closed (fixed)
Project:
Four Seasons
Version:
5.x-1.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
4 Feb 2008 at 11:21 UTC
Updated:
26 Feb 2008 at 18:24 UTC
hi,
i really like the design of the template, but after I moved it to my templates/ and configured it, I was surprised to see that the links on top to toggle colors and font-sizes arent working properly. I got an error in all browsers. Internet-Explorer was specifically saying: error in line 26, char 3, object expected and line 78, char 1 object expected.
is there anything else to do for installing this baby?
ced
Comments
Comment #1
derjochenmeyer commentedHi cedrix,
thanks for reporting this bug. The color switcher is a small hack that i always include when i develope a theme to be able to simulate different looks for myself and my customers instantly.
Its still a hack and i have to find a more stable solution for this feature if people like it.
Do you think this is an important feature? At first it was an accident that i didnt remove it before contributing the theme, but then i thought it could be a nice addon. How important is this feature?
To answer your question: Nothing special should be required to install this theme. But its still very new and so im still learning and optimizing. Im sure there are a ton more bugs to occure. Please report! :)
Comment #2
derjochenmeyer commentedComment #3
cedrix commentedhi derjochenmeyer,
thanks for your quick-reply.
to answer your question: I think the template is well designed and customizing it in color would bring it to the top.
Also i think, that instead of the user it should be the admin who can change the colors. maybe like the garmin-default style? yes, or: there's a module name "Theme Settings API" (e.g. it comes in the theme called "bealestreet"), which is also nicely customizable.
Anyhow, keep on doing that great work!
Regards
Ced
Comment #4
derjochenmeyer commentedThanks.... :)
I was thinking about using the "Theme Settings API". Its definately a feature that i want to implement!
But right now im trying to fix bugs... I'll postpone this, but not forget it :)
Comment #5
derjochenmeyer commentedPlease test new version 5.x-1.2
I'll open a new feature request for the Theme Settings API stuf
Comment #6
cedrix commentedI dont want to call it a "bug", but a CSS-suggestion:
The div of the content width is fixed to 53%.
This causes problems, because when I have a page with no right and/or left column it looks ugly to use only 53% of screen-width.
It's properly solve in the default-theme and also in the "foliage"-theme. The content always gets 100% and if there's a left column then the content flows in the remaining space.
I tried to fix it myself, but I'm not so familiar with css. When I set middle-content in style.css to either width:100% then the problem occurs that the content gets displayed below the left column (if there's any). If I cut out the "width"-setting at all, it works in IE, but in Firefox its placing the content in 100%-overall-width below the left column. I think the solution is to make an inner css-container?!
Any fixing would be great!
Hope this helps!
best regards
Ced
Comment #7
derjochenmeyer commentedfixed ... :) new version ..
Comment #8
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.