Since installing beta10, my Drupal log shows the following message when people visit nodes of a CCK node type that I have defined:
Missing argument 3 for subscriptions_ui_link() in /home/chelmsf/public_html/sites/default/modules/subscriptions/subscriptions_ui.module on line 39.

There is no subscribe link visible, and I don't think there ever has been on these nodes.

CommentFileSizeAuthor
#3 subscriptions_ui.hook_link.patch692 bytessalvis

Comments

salvis’s picture

Category: support » bug

Thanks for reporting this. Change

function subscriptions_ui_link($type, $node, $teaser)

to

function subscriptions_ui_link($type, $node = NULL, $teaser = NULL)

and just below !teaser to empty(teaser).

Do you get the Subscribe link now?

reikiman’s picture

I was seeing this issue - applied the above change - and was able to see the subscribe link.

But your change to '!teaser' I don't understand the description.

salvis’s picture

Status: Active » Needs review
StatusFileSize
new692 bytes

Here's the patch.

rallycivic’s picture

Thanks, that has stopped the messages I had in the log.

rhinokitty’s picture

For newbies like me:

Applying a patch is easy using the Linux command line utility "Patch". Type into the command line "Man patch" and it will show you information on how to use it.

How I did it:

Get all of the files in one place (desktop works) and navigate there with the command line (cd /whatever/directory/it/is). Type into the command line:

patch subscriptions_ui.module subscriptions_ui.hook_link.patch

Why? The second bit "subscriptions_ui.module" is what needs to be patched. The third bit "subscriptions_ui.hook_link.patch" is the patch that you can download from the above commend (right click save as). The first part "patch" simply tells the computer which program to use. I am on Ubuntu Gnu/Linux and this was easy to do, just a little unnerving because the command line can be intimidating. Now I feel confident in patching files! Cheers!

salvis’s picture

Version: 5.x-2.0-beta10 » 5.x-2.0-beta11
Status: Needs review » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

rallycivic’s picture

Version: 5.x-2.0-beta11 » 5.x-2.0-beta12
Status: Closed (fixed) » Active

This message has come back with beta12, but function subscriptions_ui_link is now on line 66.

I have changed line 66 to end
$teaser = NULL) rather than just $teaser)

salvis’s picture

Ah, yes, that fix was inadvertently reverted. Thanks!

It should be

function subscriptions_ui_link($type, $node = NULL, $teaser = NULL) {
salvis’s picture

Version: 5.x-2.0-beta12 » 5.x-2.0-rc1
Status: Active » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.