Todo example module is missing depenency on dynamic_subform module

drewish - February 5, 2008 - 06:08
Project:AHAH Forms Framework
Version:5.x-1.5-5
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Fatal error: Call to undefined function dynamic_subform_get_embedded() in /Users/amorton/Sites/d5/sites/all/modules/ahah_forms/examples/todos/todos.module on line 94

There's a check for the ahah_forms module before calling a dynamic_subform function so I initially assuming it was just checking for the wrong module. After changing it to check for the dynamic_subform I tried adding some todo items and ran into:
Fatal error: Call to undefined function dynamic_subform_get_prepped() in /Users/amorton/Sites/d5/sites/all/modules/ahah_forms/examples/todos/todos.module on line 402

So I'm assuming that the module really does depend on the dynamic_subform module and adjusting it accordingly.

AttachmentSize
ahah_forms_examples.diff1.35 KB

#1

starbow - February 5, 2008 - 18:00
Status:needs review» needs work

I afraid you are misunderstanding what that chunk of code does. That bit is there as an example of who to write code that can work whether or not the ahah module is enabled. It does assume that if the ahah module is around, the dynamic subforms module will be too (which is why they are both dependencies in the .info file).

#2

drewish - February 12, 2008 - 07:10

ah, i think when i'd tested it you still had the bug in the .info file that prevented the dependencies from being enforced. perhaps the best course of action would be to document that the commented out code is there for demonstration purposes.

#3

starbow - July 21, 2009 - 21:15
Status:needs work» closed
 
 

Drupal is a registered trademark of Dries Buytaert.