Support for MSN custom passport
R.Muilwijk - February 5, 2008 - 09:16
| Project: | Drupal Contact List Importer |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | hadsie |
| Status: | won't fix |
Jump to:
Description
With MSN its possible to make an account with your own email address. Unfortunatly this is currently not supported because the code is always adding '@hotmail.com'
$username[0] = $username[0] .'@hotmail.com';With this patch it's checked whether or not the user supplied a full email address and acts accordingly.
if ($provider == 'M') {
if (count($username) == 1) {
$username[0] = $username[0] .'@hotmail.com';
}
else {
$username[0] = $edit['username'];
}
}| Attachment | Size |
|---|---|
| msn_custom_passport.patch | 672 bytes |
#1
I'm marking this issue as "won't fix". The D5 version of this module is no longer being maintained. The original version had scripts that no longer worked and some that weren't compatible with the GPL. The D6 version is being developed now and is a complete re-write using the OpenInviter library. If you wish to submit a backport to D5 I'll be happy to add that to CVS. Please see the project page for more details.
#2
I notice this is still the case for D6.
Given this was raised in 2008 I am bumping this to D6 as a feature request.
The module currently wont accept custom emails for MSN :)
#3
I can re-open this for now. But I believe this is an issue with the OpenInviter code, so the issue would need to be posted with them. I'll do some more testing in the DCL code though, as it's entirely possible the issue lies there. I don't have an MSN email account so I haven't tested that one yet.
#4
#5
Thanks, good point.
I was looking inside the code, and there is a check if the mail extension is hotmail or live, and tried setting the $allowed_domains = false, but no luck,
Basically, msn used to accept any email as an msn account. That may be different today, but given it is one of the most popular stuff it would be good if it would work.
#6
What did you set allowed_domains to? I think it needs to be something like:
public $allowed_domains=array('hotmail.com', 'yourdomain.tld', 'etc.');
Does it still fail like that?
#7
It was set $allowed_domains = false as we saw it in other plugins.
The problem is, MSN allowed a few years ago any email to be registered as MSN passport not only hotmail and live like today, so we should allow for any domains I believe. :)
#8
Also, looking at the old D5 module MSN code it is quite different than the one that comes with OpenInviter.
In D5 the msn class was connecting to messenger.hotmail.com on port 1863...
http://ftp.drupal.org/files/projects/dcl_importer-5.x-1.x-dev.tar.gz
This seems like an OpenInviter issue as they are not providing such a custom email MSN class.
Setting it back to wont fix, and it is best if we post it on OpenInviter
#9
http://openinviter.com/forum/viewtopic.php?id=660
Posted request at Openinviter
#10
Great, thanks @giorgio79