Allow for custom skin paths

aaron - February 5, 2008 - 18:33
Project:jCarousel
Version:5.x-1.2
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:reviewed & tested by the community
Description

allows for something like

<?php
jcarousel_add
('rainbow', drupal_get_path('theme', 'rainbow') . '/jcarousel');
?>

AttachmentSize
jcarousel.new-paths.patch877 bytes

#1

aaron - February 5, 2008 - 18:39

oops, diff'd the wrong direction...

AttachmentSize
jcarousel.new-paths2.patch 877 bytes

#2

Wim Leers - February 5, 2008 - 18:51
Status:needs review» reviewed & tested by the community

Of course. Why didn't I do that right away?

Thanks! :)

RTBC (if I ignore the one space that violates the coding guidelines)

#3

aaron - February 5, 2008 - 18:55
Status:reviewed & tested by the community» needs review

here's another version that will also allow multiple skins to be plastered on a page, if one were so inclined. the version in cvs only allows a single skin to be applied.

AttachmentSize
jcarousel.new-paths-static.patch 861 bytes

#4

aaron - February 5, 2008 - 19:12

hmm... that version would probably add the base js more than once. not good.

here's a fixed patch

AttachmentSize
jcarousel.jq-with-paths-once.patch 859 bytes

#5

aaron - October 6, 2008 - 18:39
Status:needs review» reviewed & tested by the community

this has been ready for months. what's the deal?

 
 

Drupal is a registered trademark of Dries Buytaert.