Project:jCarousel
Version:5.x-1.2
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

allows for something like

<?php
jcarousel_add
('rainbow', drupal_get_path('theme', 'rainbow') . '/jcarousel');
?>
AttachmentSize
jcarousel.new-paths.patch877 bytes

Comments

#1

oops, diff'd the wrong direction...

AttachmentSize
jcarousel.new-paths2.patch 877 bytes

#2

Status:needs review» reviewed & tested by the community

Of course. Why didn't I do that right away?

Thanks! :)

RTBC (if I ignore the one space that violates the coding guidelines)

#3

Status:reviewed & tested by the community» needs review

here's another version that will also allow multiple skins to be plastered on a page, if one were so inclined. the version in cvs only allows a single skin to be applied.

AttachmentSize
jcarousel.new-paths-static.patch 861 bytes

#4

hmm... that version would probably add the base js more than once. not good.

here's a fixed patch

AttachmentSize
jcarousel.jq-with-paths-once.patch 859 bytes

#5

Status:needs review» reviewed & tested by the community

this has been ready for months. what's the deal?

#6

Status:reviewed & tested by the community» needs work

It seems this patch is out of sync now. Sorry, aaron.

#7

Status:needs work» closed (won't fix)

Rather than using custom skin paths, we now have a skin registry in 2.x (see #426774: jCarousel Skin Registry (hook_jcarousel_skins)), but if you prefer you could simply drupal_add_css() your own skin file manually and then use a matching skin name when you call jcarousel_add().

Support has ended for the 5.x version, so I'm moving this to won't fix.

nobody click here