Enable Drupal filters

Encarte - February 5, 2008 - 22:38
Project:Annotate
Version:5.x-1.0
Component:Code
Category:bug report
Priority:normal
Assigned:clemens.tolboom
Status:closed
Description

I tested Annotate-private and the resulting annotation seems to disregard Drupal filters (like standard HTML filter or site customized filters). It doesn't even break lines which causes the complete annotation to stand in a single line. The concept of this module is extremely interesting and I would like to test it further (but, for now, in my opinion, this is really a major and basic issue).

#1

clemens.tolboom - February 6, 2008 - 08:19

You are absolutely right. It is strange no one else noted this ommision.

I fixed it right away, but have no time to test right now.

#2

clemens.tolboom - February 6, 2008 - 08:20
Assigned to:Anonymous» clemens.tolboom
Status:active» fixed

#3

clemens.tolboom - February 9, 2008 - 07:49
Status:fixed» postponed (maintainer needs more info)

Filtering has no visible effect. Where should it be? My guess is that the listing on the annotations tab should be better.

Can you please elaborate where you note that this occurs?

#4

Encarte - February 9, 2008 - 19:14

Clemens, I've just downloaded and tested the new version (updated February 9, 2008 - 12:00). The edit form now shows the filtering options, but, if you choose Filtered HTML or Full HTML, it seems to have no effect on the results.

Example:

When I wright this in the edit form:

Testing line 1

<strong>Testing line 2</strong>

I would expect to get something like this in the annotate tab (i. e., in the resulting message):

Testing line 1

Testing line 2

Instead, I get something like this:

*Text TitleUser1privateTesting line 1 <strong>Testing line 2</strong>Saturday, 02/09/2008 - 19:05

I hope this information can help you.

#5

clemens.tolboom - February 10, 2008 - 06:20
Category:feature request» bug report
Priority:critical» normal
Status:postponed (maintainer needs more info)» active

Thanks for your feedback.

So this feature request now promoted to a bug and prioritised to normal is about:
- working input filterting ... extra db column note_filter
- better listing ... displaying the note formatted
- better listing ... more styled

I hope to fix this bug next week.

When you have some more input on the display your welcome.

#6

Encarte - February 16, 2008 - 16:43

The main issue is now solved: annotations are being filtered and this module is a serious candidate to answering the question in http://groups.drupal.org/node/3720.

But there seems to be a problem: only the default filter defined for the site seems to be working. If, for instance, my default site filter is «Filtered HTML» and I choose «Full HTML» in the annotation form, the module seems to ignore my option and it shows the annotation filtered with «Filtered HTML». I hope it's a simple issue to solve.

#7

clemens.tolboom - February 17, 2008 - 08:45

Yeah ... i noted this the other day ... i need to add the used format to the database.

As i want to release a final annotate (private) i try to fix this today.

Have you noted that wispering module is abandoned!

#8

clemens.tolboom - February 17, 2008 - 10:25
Priority:normal» critical

My annotations are deleted even when there is text in it!

So don't use dev for annotate!!!

Haven't time to fix this today ... so next week :-/

#9

clemens.tolboom - February 24, 2008 - 08:49
Priority:critical» normal
Status:active» fixed

Formats are now enabled for annotate (private)

#10

clemens.tolboom - February 24, 2008 - 08:52

Formats are now enabled for annotate (private)

#11

clemens.tolboom - February 25, 2008 - 10:41
Version:5.x-1.x-dev» 5.x-1.0

#12

Anonymous (not verified) - March 10, 2008 - 10:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.