Enabling module breaks theme layout

John Bryan - February 6, 2008 - 14:39
Project:Style (CSS) Settings
Version:6.x-1.3
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:needs work
Description

When using a custom theme (I don't know if theme specific) - just the act of enabling the module, with no changes to the theme's "style.css", breaks the theme layout. Disabling the module caused the style to return.

#1

fokke - February 8, 2008 - 09:01
Status:active» postponed (maintainer needs more info)

Hi John,

I would need some more info on this to reproduce. What theme were you using? And could you send me the rewritten style.css that was produced by the module? Just look in the HTML, find the /sites/all/default/files/....style.css and download it, and post it here as attachment. Thx!

F

#2

John Bryan - February 8, 2008 - 15:15

The theme is evolved from a very custom 4.7 site that I have inherited responsability for:-

The Drupal 6 development site in question is www.CliveJames.com; the original 4.7 site is currently at www.CliveJames.com

The Nice menus CSS is now redundant as they have been dropped from the design, not sure if they were active at time of testing this module.

Will re-run the test as soon as I have a chance.

Regards

AttachmentSize
style.css_.txt 12.62 KB
page.tpl_.php_.txt 4.51 KB

#3

John Bryan - February 8, 2008 - 15:26

AHH,

Just realised the re-written CSS bit (doh). Will re-enable the module and try to locate it despite the WSOD as soon as I can (but may be a few days). The previous attachments are the themes own style sheet etc.

Regards

#4

John Bryan - February 8, 2008 - 21:59

The HTML frontpage when the module is enabled (see full version attached) contains the following CSS links:-

  <link type="text/css" rel="stylesheet" media="all" href="/modules/node/node.css?Y" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/system/defaults.css?Y" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/system/system.css?Y" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/system/system-menus.css?Y" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/user/user.css?Y" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/fckeditor/fckeditor.css?Y"

/>
<link type="text/css" rel="stylesheet" media="all"

href="/files/style/0402cf83a81225b0369af06b137aac64.style.css?Y" />

<!-- link href="/styles/stylesheet.css" rel="stylesheet" type="text/css" -->

"0402cf83a81225b0369af06b137aac64.style.css" is attached. but there is also a reference to a non-existent "/styles/stylesheet.css" which I can not locate, there is not even a "/styles/" directory for it to exist in!.

I have just tried adding the 6.x-1.3 version of the "Theme Settings API", although presumably the built in version of the api within Drupal 6 should work?

Also attached is a screen shot, to see how it should look go to www.CliveJame.info - so long another experiment hasn't broken it ;¬)
Last time I ended up with WSOD after a while and had to revert to remote alteration of the actual SQL database to disable the module. This time it just losses styling in the custom style and leaves the admin "BlueMarine" theme intact and functional.

Regards

AttachmentSize
homepage.html_.txt 6.66 KB
0402cf83a81225b0369af06b137aac64.style_.css_.txt 5.66 KB
lost-style.jpg 142.76 KB

#5

fokke - February 9, 2008 - 15:05

John,

The /styles/stylesheet.css is hard-coded in the page.tpl.php in one of your earlier posts so this has nothing to do with the Style Settings module.

Something for you to check would be: Are there any differences between your original style.css and the rewritten one? Just do a diff. If that's not the case, the fault is not in Style Settings since that's the only thing it does.

#6

John Bryan - February 14, 2008 - 00:59

There is no similarity between the generated CSS content and the theme's style.css. see attached "style.css.txt" and compare with the generated css file attached previously

P.S.
"/styles/stylesheet.css" is an obsolete and now removed link - therefore not the cause

AttachmentSize
style.css_.txt 11.56 KB

#7

fokke - February 14, 2008 - 07:56

I really don't get this.... if style.css_.txt is your theme's stylesheet, and the rewritten one is completely different, then what stylesheet is the module rewriting?

Please send me the URL of the site your working on and - if possible - a login (to fokke@zo.nu).

Thx

#8

John Bryan - February 14, 2008 - 08:25

As per previous the URL is www.CliveJame.info

But, if this is just me suffering then don't worry too much as it is not important to this site. I just posted for your information.

Regards

#9

tomaszx - March 21, 2008 - 11:00

just remove from line 31 in style_module

find:
$old_data = file_get_contents(file_exists(base_path().$old_path) ? $old_path : url($old_path, array('absolute' => TRUE)));

replace:
$old_data = file_get_contents(file_exists($old_path) ? $old_path : url($old_path, array('absolute' => TRUE)));

looks like base_patch() i not needed and generate some problems

#10

tomaszx - March 21, 2008 - 11:01
Status:postponed (maintainer needs more info)» needs work

#11

tomaszx - March 26, 2008 - 12:02
Version:6.x-1.1» 6.x-1.3
 
 

Drupal is a registered trademark of Dries Buytaert.