zeryn reports:

If no roles are chosen in the admin page:
- anonymous users see the bookmark links in grid view but not in the full node view
- users with roles can't see the bookmark links in either the grid or the full node view

If some or all roles are chosen, everything works as expected.

Comments

zeryn’s picture

zeryn commented

subscribing

mooffie’s picture

mooffie commented
Priority: Normal » Critical

I'm marking this bug 'critical' because an admin is likely to fall victim to it.

mooffie’s picture

mooffie commented
Title: when no roles are selected... » If no roles are chosen in the admin page...

I've commited a a fix that prevents this from happening to future bookmarks. However, to complete this fix I should write an upgrade path that fixes existing bookmarks. And to do this I'd prefer that first we decide on the misleading interface issue I've just opened.

(The bug had to do with how FAPI handles checkboxes. When no roles were selected it was as if the 'anonymous user' role was selected.)

mooffie’s picture

mooffie commented
Status: Active » Fixed

Patch commited.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.