Sorry, this may be a dense question -- but if I've granted a Role the permission to Update & Delete nodes with a certain term, should users with that role be able to edit an unpublished node that's tagged with that term?

And if a node *does* have to be published before TAC permissions apply, is there a (practical) way to override that requirement?

I'm trying to use this module for a groupblog site, so that editors of particular blogs can review and then publish (using Actions & Workflow) nodes that have been submitted by other bloggers. I could have sworn that I had it working with unpublished nodes, but it's definitely not allowing that access now. Once a post is live, though, the TAC controls work exactly as one would expect them to.

So I want to be sure that I'm clear on how it's *supposed* to work -- so I can either start looking for the conflict that we've created, or find another way of structuring our editing/publishing process.

Thanks for your help!

CommentFileSizeAuthor
#6 node-unpublished access for TAC D5.9.patch2.36 KBrealityloop
#5 node-unpublished access for TAC D5.8.patch2.36 KBrealityloop
#3 node-unpublished access for TAC D5.7.patch2.36 KBrealityloop

Comments

keve’s picture

keve commented

As far as i know, access modules ONLY work with publish nodes: (where $node->status == 1)

look at function node_access() in node.module (v.5.7) line 2730

  // If the module did not override the access rights, use those set in the
  // node_access table.
  if ($op != 'create' && $node->nid && $node->status) {

If unpublished, drupal does not grant access even if user has any kind of TAC permission.

(Only if user (like user 1) have right to see unpublished nodes anyway.)

TKS’s picture

TKS commented

Thanks keve, for the quick reply. Now I can dive into figuring out a new approach, without wondering if I'd just checked the wrong box somewhere!

realityloop’s picture

realityloop commented
StatusFileSize
new node-unpublished access for TAC D5.7.patch2.36 KB

Here's my first take at a patch against Drupal 5.7 node.module that will grant access to edit unpublished nodes allowing editors to update them (if they have access), while still making them inaccesible to Anonymous users.

TKS’s picture

TKS commented

Hey, thanks! Not sure whether keve thinks this *should* be a feature, but I'm happy to test it out. (It'll probably be this weekend before I get the chance.)

realityloop’s picture

realityloop commented
StatusFileSize
new node-unpublished access for TAC D5.8.patch2.36 KB

Updated for Drupal 5.8

I'm not sure if it would be possible to add even finer grained control, I believe this only stops an anonymous user from accessing unpublished nodes, I'm pretty sure a logged in user will still be able to see them if they go direct to the URL

realityloop’s picture

realityloop commented
StatusFileSize
new node-unpublished access for TAC D5.9.patch2.36 KB

Updated for Drupal 5.9

keve’s picture

keve commented

I do not plan to include in TAC any patch for drupal core.

If you would like to add this feature in future drupal version, make on issue for node.module in core.

cpugeniusmv’s picture

cpugeniusmv commented
Status: Active » Closed (won't fix)