i'm lost...

ajudson - February 7, 2008 - 09:02
Project:Subversion
Version:5.x-2.x-dev
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:active
Description

Hi i've been trying this module but just can't get it to retrieve any file listing / messages from any of the subversion repositories i work with. Its also not displaying any errors and the apache logs aren't showing any either... I've tried every combination of path to the subversion binaries and repositories but nothing seems to be making any difference.... any suggestion ???

Andy.

#1

ajudson - February 7, 2008 - 10:03

update... i've told it to log progress to watchdog.., and now capturing errors, which are actually consistent with error i've got with another module - i.e. extra "em" tags (although this maybe a problem with watchdog)... see log

Error Fetching subversion log(<em>http://localhost/svn/</em>): <em>&#039;c:/temp/svnbin/svn.exe&quot; log -r 0:HEAD --incremental --non-interactive --xml -v --limit 100 &quot;http://localhost/svn/&#039; is not recognized as an internal or external command, operable program or batch file.</em>.

update: the error goes away if i change the path to "c:\temp\svnbin\" but i still don't get any logs / files returned

#2

halkeye - February 12, 2008 - 04:01

That seems to be a very weird quoting, a " where its not supposed to be, a ' too.

Have you made any changes to the code?

I've updated the CVS code with less escaped watchdog message.

If you update to the latest code, and get the same error, can you paste it again?

(sorry for the delay, my laptop was in the shop)

#3

ajudson - February 13, 2008 - 15:52

Thanks but i'm currently not gettting any errors in the logs as the path is defined as shown in the update part of the message above. I've not changed any of the code, but i've seen a similar problem with another module - makes you think drupal core changed something in the watchdog module.

ignoring the log message issue, do you have any suggestions as to why i'm not getting any listings / logs from the subversion repositories ?

#4

leop - February 18, 2008 - 16:19

I've written some code that should give you more info about error messages in listings and / or logs: http://drupal.org/node/220860. You could also implement this whenever an exec command is used.

#5

ajudson - February 22, 2008 - 13:17

sorry for not being of much use on this one, but i've added the code as described and nothing was returned. I tried adding it after other exec commands but that generated error relating to the added code... i'm not a php developer so i don't know what i need to change.

e.g. i get the following response when i add it after exec(implode(' ', $cmd), $log, $return_code); in function subversion_fetch_repository

warning: array_filter() [function.array-filter]: The first argument should be an array in C:\Documents and Settings\ajudson\My Documents\SANDBOX\WebDev\hicdev\sites\default\modules\subversion\subversion.module on line 2023.

#6

leop - February 26, 2008 - 18:05

It sais:

This code could easily be adjusted to work at other places where an exec command is given.

for example, if you add it after exec(implode(' ', $cmd), $log, $return_code);, you need to change the word $output into $log. Likewise, if you add it after exec(implode(' ', $cmd), $out);, you need to change the word $output into $out. That is how PHP works.

#7

halkeye - February 26, 2008 - 19:56

I havn't really had time to work on this, but I do have an early version of the code that might work.

replace your subversion.module with http://quackduck.halkeye.net/subversion.module.txt and see if that works, it should add alot more logging. I'm just worried about how much data is exposed.

Note: i'm going to try to see how much time I have to port things to the vcs module and let that one be activly be maintained.

#8

ajudson - February 27, 2008 - 09:00

Thanks for your efforts on this, and its good to hear that your planning to port this to the vcs module. I've used the replaced module as you've attached, that generates the following messages when i try to browse e.g. the trunk

    * Subversion Error: Generating Diff: .
    * warning: Invalid argument supplied for foreach() in C:\Documents and Settings\ajudson\My Documents\SANDBOX\Drupal\sites\localhost.hicdev\modules\subversion\subversion.module on line 2315.

and when it checks the logs, the following is returned

Subversion Error: Fetching subversion log: .

 
 

Drupal is a registered trademark of Dries Buytaert.