Template code is incorrectly placed, missing check.

Great! I didnt have the time to investigate this... But its however a little more complex to setup then... now its easy "copy this code there"...

Modifying the _phptemplate_variables respectively adding it if it doesnt exist could be hard for new or unskilled users..

This is what we would have to add (replace) in the documentation and on the description page, right?

Place the following code in your themes template.php file in the page section of the function _phptemplate_variables()

    if(module_exists('javascript_aggregator') && $vars['scripts']) {
      $vars['scripts'] = javascript_aggregator_cache($vars['scripts']);
    }

If that function does not exist in your template.php file add it by pasting the follwoing code

/**
 * Override or insert PHPTemplate variables into the templates.
 */
function _phptemplate_variables($hook, $vars) {
  if ($hook == 'page') {

    if(module_exists('javascript_aggregator') && $vars['scripts']) {
      $vars['scripts'] = javascript_aggregator_cache($vars['scripts']);
    }

    return $vars;
  }
  return array();
}

If your theme does not come with a template.php file create an empty text file and name it template.php them past the code above with an <?php opening tag! and save it to the directory of your theme. Check the core module garland for an example of a template.php

I'm not sure where this should go, my template.php looks a little different:

function phptemplate_variables($hook, $vars) {
  switch ($hook) {
    case 'page':   
      // Add page template suggestions based on node type, if we aren't editing the node.
      if ($vars['node'] && arg(2) != 'edit') {
        $vars['template_files'][] = 'page-nodetype-'. $vars['node']->type;
      }
      break;
  }
  return $vars;
}

Any suggestions?

Instead of an if-Statement you do have a switch-Statement, but it is pretty much the same as shown in #3. Your complete code would look like this:

function phptemplate_variables($hook, $vars) {
  switch ($hook) {
    case 'page':  
      //javascript aggregation
      if(module_exists('javascript_aggregator') && $vars['scripts']) {
        $vars['scripts'] = javascript_aggregator_cache($vars['scripts']);
      }

      // Add page template suggestions based on node type, if we aren't editing the node.
      if ($vars['node'] && arg(2) != 'edit') {
        $vars['template_files'][] = 'page-nodetype-'. $vars['node']->type;
      }
      break;
  }
  return $vars;
}

thanks a lot for complex stuf, but i have some trouble:

my

function _phptemplate_variables($hook, $vars) {
  if (module_exists('advanced_forum'))
  {
    $vars = advanced_forum_addvars($hook, $vars);
  }
  if(module_exists('javascript_aggregator') && $vars['scripts']) {
      $vars['scripts'] = javascript_aggregator_cache($vars['scripts']);
    }
  global $_REQUEST;
  $styles = false;
  $q = explode('/', $_REQUEST['q']);
  $av_pages = array();
  $av_pages[] = array('node', 'add');
  //$av_pages[] = array('node', '*', 'edit');
  $av_pages[] = array('admin');
  
  foreach($av_pages as $av)
  {
      $m = 0;
      foreach($av as $index => $a)
      {
        if($q[$index] == $a || $a == '*')
        {
            $styles = true;
            $m++;
        }
        else $styles = false;
      }
      if($m == count($av)) break;
  }
  
  $css = drupal_add_css();
  if(!$styles)
  {
    //unset($css['all']['module']['modules/system/system.css']);
    unset($css['all']['module']['modules/system/defaults.css']);
  }
  $vars['styles'] = drupal_get_css($css);
  return $vars;
}

after it i have all fine with front page, but on all pages, there i am going at my drupal site i see doubling js scripts

after pushing refresh button js loaded only once, but with clicking on another link, referalling from this site, each js loaded twice

anybody know reasons or any minds about it?
disabling aggregation on perfomance page have no luck

i can reply for this by myself

twice js Chrome dev (see attach)

i thought what scripts loaded twice and its my mistake (Cached JS reguest method: empty [browser: Chrome], Cached JS reguest method: GET [browser: Chrome]), but chrome tell, what he had first JS with empty request and second for same js with GET

anybody can explain it?

Yslow tells us what FireFox have no double requests to JS (Yslow JS Components)

all files cached (WEIGHT GRAPHS)

so, i see, what in this case module works fine and we need to understand: or it is Google chrome bug or google knows this stuff better than Yslow

this is very useful for me....

sub