The sender of the mail(s) is not the author of the transition using workflow module

prunelle - February 7, 2008 - 15:11
Project:Action email role
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review
Description

The email of the sender is the email that is set in the global informations of the site. I'm running the action via a transition of a workflow (workflow module) and I would expect that the email of the sender would be the email of the author of the state changing. What do you think of that ?

Thanks for your answer.

#1

eliza411 - May 26, 2008 - 01:13
Category:support request» feature request

That would be a useful option, indeed. Toward the same end, I think, would be a variable to allow you to include the names of all the people who received the e-mail in the body or from: field of the e-mail.

#2

dgtlmoon - May 26, 2008 - 01:33

eliza, it sounds like your comment and this post are different issues?

#3

eliza411 - May 27, 2008 - 05:51

Yes, I was making a related note (making variables available to work with) but it's not the same issue at all.

#4

jeff.ferrari - June 7, 2008 - 17:26
Version:5.x-1.x-dev» 5.x-2.x-dev
Status:active» needs review

I thought the 2 ideas above were pretty cool, and I actually had a use for them. Attached are the patches for the respective features. They were pretty rapidly kludged together, so feel free to input on a better way of doing them.

condense_recipients.patch adds a configuration checkbox. Instead of multiple calls to drupal_mail() , it just gathers all the emails up then calls it once with all emails in recipient field.

change_sender.patch also adds a configuration checkbox. When checked, it grabs the global $user object and uses the email address found there. I tested with workflow.module, but prob will work with any trigger that has a $user global set (not cron).

Both have only undergone rudimentary testing, ymmv ;)

AttachmentSize
change_sender.patch 1.93 KB

#5

jeff.ferrari - June 7, 2008 - 17:31

Hmm... can't get other patch to upload. Doesn't belong here anyway ;)

http://drupal.org/node/267921

#6

unrealnighthawk - January 28, 2009 - 22:44

+1 this is also an awesome idea and would be very helpful. Can this get into the next version of the module please?

#7

marcp - February 5, 2009 - 22:51
Version:5.x-2.x-dev» 6.x-1.x-dev

Here's a patch for the D6 version. Any chance of this getting in, or should we go about this in a different manner (ie. hook_mail_alter)?

AttachmentSize
change_sender_d6.patch 2.23 KB

#8

marcp - March 5, 2009 - 22:42

Just checking on this to see if it's on the radar. We've been using this patch for a while now without any problems.

#9

v1nce - March 6, 2009 - 02:00

Do we have any others that have reviewed this patch or have it implemented? Having this as a configuration option seems fine. However, in the event the email being used as the sender is from a different domain, it will probably end up in a junk mail folder. Should we implement another option that will use the author of the transition if their email is from the same domain as the site, otherwise use the default site email?

Thoughts?

 
 

Drupal is a registered trademark of Dries Buytaert.