Do not display useless terms
ricflomag - February 7, 2008 - 19:50
| Project: | Taxonomy Search Module |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | ricflomag |
| Status: | needs review |
Description
Here is a patch that intends to fix three bugs:
- The major one: useless terms do not show anymore in the selection list: when the user selects a term, there is always at least one selectable node.
- Corrected a wrong usage of the t() function.
- Added a strip_tags() to the output of _nodereference_item() when filling the list of selectable nodes, to cut off the noisy HTML that this function may produce.
Anyone to test and review this?
| Attachment | Size |
|---|---|
| taxonomySearch.module.patch | 2.02 KB |
#1
New version of the patch that fixes a problem with the indexes of the of the options in the taxonomy select box, and allows no filtering at all when the "Please choose" option is selected (instead of having an empty node selection list).
Still anyone to review it ?
#2
THANKS for the patch, I'm going to commit it, and release a new version of the module, with the content_taxonomy listed as a dependency
#3
Glad to read this. Thanks.
#4
Slightly modified patch:
* Removed the strip_tags() function on _nodereference_item() return value, replaced by setting the third argument of this function to FALSE, so that it does not return HTML, but plain text.
* Done on both calls to _nodereference_item() (one had been omitted).
Any chance to release a new version soon ? ;)