Forum icon support is broken [#21918]

The forum icon support is broken in 4.6 - currently if an icon path is provided in the user interface, it gets ignored anyway!

Changes required in the function _forum_icon() of forum.module. The main problem is the hardcoded path to the icons is currently:

$file = "misc/forum-$icon.png";

$output = theme('image', $file);

This is easily fixed by moving the 'misc' path to the variable_get() at the start of the function.
Then changing the way the $file variable is built up, as below.

$base_path = variable_get('forum_icon_path', 'misc');
...
$file = "$base_path/forum-$icon.png";

Comment	File	Size	Author
#3	Forum.Image.Display.Folder.Issue.patch	514 bytes	robin monks

Comments

Comment #1

budda

English

Cheshire

commented 5 June 2005 at 19:46

Priority:

Normal

» Critical

I'm having to modify Drupal core installs to fix this bug in forum.module.
Has it been addressed at all in CVS yet?
Sorry I've not submitted a patch to apply the fix.

The bug still exists in 4.6.1 release.

Comment #2

killes@www.drop.org commented 11 June 2005 at 21:33

Priority:

Critical

» Normal

A missing icon is certainly not critical.

Comment #3

robin monks commented 11 June 2005 at 21:54

Version:	4.6.0	»
Assigned:	Unassigned	» robin monks

Status	File	Size
new	Forum.Image.Display.Folder.Issue.patch	514 bytes

Here it is in patch form. I'll take responsibility of any required updates.

Robin

Comment #4

slidenby@twit.slidenby.com commented 17 June 2005 at 18:10

I know I'm going to come off like an idiot... and I'm sorry... but can someone please quickly explain to me how to install this patch? I looked at the forum.module code and I see where the corosponding code is for the image locations... I'm just not exactly what I'm supposed to do from there, copy the code in the patch file?
Thanks, sorry again for being a noob at this