This discussion branches off of this issue to add the ability to reference external Javascript files using drupal_add_js.

This issue tracks the ability to cache these external Javascript files.

CommentFileSizeAuthor
#5 219346.patch2.57 KBrobloach

Comments

robloach’s picture

robloach
he/him
commented
Status: Active » Postponed

Drupal_add_js() has to get external javascript support first.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Subscribing. This is a must for better page loading performance.

davidtrainer’s picture

davidtrainer commented

This is an important enhancement for Translatable Comments.

robloach’s picture

robloach
he/him
commented
Status: Postponed » Closed (duplicate)

Moved to the reinvention of drupal_add_js: http://drupal.org/node/251578#comment-871405

robloach’s picture

robloach
he/him
commented
Status: Closed (duplicate) » Needs work
Issue tags: +JavaScript, +Patch Spotlight
StatusFileSize
new 219346.patch2.57 KB

Would be good to have SimpleTests......

Also have to figure out what to do if the file doesn't return a successful return code.

hass’s picture

hass commented

For caching external files it is *very* important to have an auto clean-up feature. Additional you need to wipe the locally cached files if the clean up button is clicked on performance page. You can find an example for the auto clean-up in the Google Analytics module... the remote and locally cached file can change and therefore it will be deleted after one day and downloaded again if requested first. I think this is basic functionality for this caching feature and needs to be added to the above code.

xjm’s picture

xjm
she/her
Primary language English
commented

Tracking.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Closed (fixed)

Cleaning up the issue queue.

vasrush’s picture

vasrush commented

Hope that this will help other D6 users

http://drupal.org/project/cache_external_files

philbar’s picture

philbar commented
Status: Closed (fixed) » Needs work

Did #5 and #6 get addressed?

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 7.x-dev » 8.x-dev
Status: Needs work » Postponed

I'm worried this will introduce a lot of problems. Hopefully when JS processing will be pluggable it'll be easy to add for contrib.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 8.x-dev » 9.x-dev
Status: Postponed » Needs work

Let's not deal with cache invalidation of remote scripts in core for D8.

catch’s picture

catch
he/him
Primary language English
commented
Version: 9.x-dev » 8.1.x-dev
Issue summary: View changes
Issue tags: -Patch Spotlight +front end performance

I have a 6.x module that does this: https://www.drupal.org/project/asset_cache

We could add this in a minor version if we wanted to.

yesct’s picture

yesct commented
Issue tags: -front end performance +frontend performance

making tag the more common one so we can delete the lesser used one so it does not show in the autocomplete

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Active

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Closed (won't fix)
Issue tags: -JavaScript +JavaScript

I don't think this is core job, also these days people don't expect their CMS to handle that type of assets like this (also the excessive amount of tracking would make cache management a nightmare).