http://drupal.org/cvs?commit=99532 - after this commit FeedAPI stopped deleting expired feed items. I think I have found the problem. The following line of _feedapi_invoke_refresh()

$counter['expired'] = feedapi_expire($feed, $force, $settings);

should be like this:

$counter['expired'] = feedapi_expire($feed);

Comments

Leeteq’s picture

Subscribing.

aron novak’s picture

Assigned: Unassigned » aron novak
Status: Needs work » Postponed (maintainer needs more info)

Well, I tested on my site and my old items do expire. So i'm in doubt. Btw, i committed mustafau 's patch. (at least, it makes the code nicer :) ) Can you tell me it helps or not?

mustafau’s picture

Title: Feed items do not expire » Outdated feed items are being saved

Lines 1141 and 1149 of feedapi.module has references to uninitialized variable $settings.

aron novak’s picture

Status: Postponed (maintainer needs more info) » Fixed

Thanks for the usual very exact description :)
It's fixed, committed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.