Integrate Invite with 3x version of Userpoints
ebeyrent - February 8, 2008 - 18:50
| Project: | User Points Contributed modules |
| Version: | 5.x-3.x-dev |
| Component: | Code: userpoints_invite |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
I have created a patch to use the new api in userpoints 3x.
| Attachment | Size |
|---|---|
| userpoints_invite.020708.patch | 3.49 KB |
#1
Hooray! Will test tonight.
#2
ebeyrent, is this patch tested?
IceCreamYou, please confirm if it works for you, I will then commit it.
#3
I can confirm that it works on Drupal 5.5, PHP 5.2.5, MySQL 5.0.45, on an Apache/2 webserver, for the most part.
Points are awarded appropriately on invites and registry, as well as withdrawn invitations. However, points are not detracted when a user account is deleted (as they're supposed to be if a certain setting is enabled). This means that if users are allowed to delete their accounts, they could keep inviting and then deleting a second account, racking up the points as they did so.
It's not a major problem though. Most sites don't allow users to delete their accounts, and I'm not even sure the original module worked for this either.
In my opinion, this can be committed. I didn't test it extensively and I only tested it on my one site, but the code looks accurate to me. The change is minor--really, just a single command was changed to use the 3.x API.
Thanks to both Userpoints maintainers and ebeyrent.
(I'm running the latest stable version of Userpoints (3.3 I think) and the latest version of Userpoints Contrib.)
#4
Thanks for the patch, and thanks for testing.
This is now in CVS.
#5
Automatically closed -- issue fixed for two weeks with no activity.