Link to comments doesn't use page number
| Project: | MySite |
| Version: | 5.x-2.19 |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
I'm lucky in that I'm getting tons of comments on content at Anderson Free Press (http://www.andersonfreepress.net)
However, there's an issue (in a lot of places) in that the links to new comments don't work because they don't have the page number in them.
The changes I make to get this working in tracker and elsewhere can be found here...
http://libcom.org/forums/feedback/jump-straight-to-last-post?page=3#comm...
I hear this won't be a problem in D6 anymore (jumping to new comments), and I'm not sure it affects a lot of people ... so no rush on a fix. I wanted to let you know, though.
I noticed it with using "Add Post Comments" - it shows everything fine, but since the thread is multiple pages, the links don't work because they don't include page number.
Hope all that made sense. Been a long week, but I wanted to get this down somewhere...
Thanks,
kpaul
#1
That does make sense. Not sure how to account for it.
The link does go to the proper parent node, right?
#2
Yes, it goes to the proper node. Here's a link to a forum thread with 20 comments...
http://www.andersonfreepress.net/anderson-forums/news-talk/5832?page=1#new
the #new doesn't work unless you have the page=1 in there. It's missing throughout Drupal, though. (But is supposed to be fixed in D6, I think...)
So, when I "Add Post Comments" it shows each comment as a link to the comment, but w/out the page=1 for threads with more than one page, it doesn't go to the right comment...
Sorry if I wasn't clear enough...
-kpaul
#3
For example, the links to individual comments in the mysite block are coming out:
http://www.andersonfreepress.net/anderson-forums/news-talk/5766#comment-...
which doesn't work if I have the comments split to 10 per page and have 150+ comments on a thread...
http://www.andersonfreepress.net/anderson-forums/news-talk/5766?page=17#...
that is what the link should be... so it's not taking into count total number of comments and comments per page setting...
thanks.
#4
You would have to run some logic in the function
mysite_type_comment_data().I think that comment_block() has this same issue.
You want to take a crack at patching this?
#5
I did look very quickly at the table structure for comments, and I'd like to see how this was solved in D6, because deriving the page # for a comment is not trivial.
#6
I heard it was solved in D6. I haven't confirmed this myself yet.
I'll put it on my list, but not sure when or if I'll be able to get to it...