Hello again! I really like how you allow for the customization of labels now. One thing I did notice is that it doesn't work so well when you end up changing the label such that it doesn't match the description. You'll notice in the example below that I changed "Droplets" to "Witlets" but the change isn't applied to the description.

Add Witlets
Droplets are helpful tools that you can add to your personal page. Search by name or select from the list provided.
CommentFileSizeAuthor
#4 text_change.patch2.43 KBagentrickard
#4 profile.patch503 bytesagentrickard

Comments

WISEOZ’s picture

WISEOZ commented

Just adding another observation to this one ...

For whatever reason, the Profile label and target settings don't save.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Thanks. That was someone else's patch, and it obviously needs work. http://drupal.org/node/174673

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Category: support » bug
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review
StatusFileSize
new profile.patch503 bytes
new text_change.patch2.43 KB

Two patches.

One to add descriptions to the editable elements.

One to fix the error in profile.inc

WISEOZ’s picture

WISEOZ commented

Both patches appear to be doing what's intended but I'm getting this error now within MySite admin pages.

    * warning: include_once(sites/all/modules/mysite/plugins/types/profile.inc.inc) [function.include-once]: failed to open stream: No such file or directory in /usr/local/apache2/htdocs/drupal/sites/all/modules/mysite/mysite.module on line 3521.
    * warning: include_once() [function.include]: Failed opening 'sites/all/modules/mysite/plugins/types/profile.inc.inc' for inclusion (include_path='.:/usr/local/lib/php') in /usr/local/apache2/htdocs/drupal/sites/all/modules/mysite/mysite.module on line 3521.
    * warning: include_once(sites/all/modules/mysite/plugins/types/profile.inc.inc) [function.include-once]: failed to open stream: No such file or directory in /usr/local/apache2/htdocs/drupal/sites/all/modules/mysite/mysite.module on line 3521.
    * warning: include_once() [function.include]: Failed opening 'sites/all/modules/mysite/plugins/types/profile.inc.inc' for inclusion (include_path='.:/usr/local/lib/php') in /usr/local/apache2/htdocs/drupal/sites/all/modules/mysite/mysite.module on line 3521.
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

That's some sort of odd bug based on filenames. Check your plugins/types directory. The file should be called 'profile.inc' not 'profile.inc.inc'

WISEOZ’s picture

WISEOZ commented

I didn't have a profile.inc.inc but I do have a profile.inc.backup I had created. I moved that up one directory and the error is now gone.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Yup. That was the problem. The file was getting parsed twice. (Or trying to and failing.)

This has been committed to HEAD.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.