this was showing blank messages. patch fixes the definition so that when the settings page is built the token fields show up and are named correctly which then does the token translation correctly.

applies to modules/contributions/modules/activity/contrib/buddylistactivity/buddylistactivity.module

CommentFileSizeAuthor
#13 buddylistactivity.JPG39.76 KBWISEOZ
#9 Activity Settings Activity Testing.png213.72 KBsirkitree
#8 activity.PNG33.15 KBWISEOZ
#4 buddylistactivity_definition_5.patch4.43 KBsirkitree
#3 buddylistactivity_definition_4.patch4.63 KBsirkitree
#1 buddylistactivity_definition_2.patch4.34 KBsirkitree
buddylistactivity_definition.patch1.89 KBsirkitree

Comments

sirkitree’s picture

sirkitree commented
StatusFileSize
new buddylistactivity_definition_2.patch4.34 KB

Ok here's an updated patch that makes so the buddies' activity block works.

Also gives you buddylistactivity_page to see your buddies' activity in table format.

Only local images are allowed.

Please someone test this out cuz I wanna commit it ASAP if it's working well. Seems to for me so far.

sirkitree’s picture

sirkitree commented

Worth noting...

This will only allow you to see buddylist activity for your friends, due to the new 'target' system. Since the other contrib modules do not implement the 'buddy target', their activity will not show up. Should probably fix this by putting checks in the other contrib modules... *sigh... this could be come tedious though. Other contribactivity modules supporting the ones that deal with relationships...

This basically means there are the relationship contrib modules (buddylist, buddylist2, noderelationships, etc.) and then there are the contrib modules that need to implement these as targets if they exist. Seems messy.

sirkitree’s picture

sirkitree commented
StatusFileSize
new buddylistactivity_definition_4.patch4.63 KB

Noticed that i was getting errors when switching to another user. This was because I did not put in access checks, but also because there is a check if is_array on the $uids passed to _block and _page and the buddylistactivity is creating the $uid variable with
array_keys(buddylist_get_buddies($user->uid, 'uid'));

This needed a check to make sure we're getting an array from this first and if it's only one (cuz it might be if the user only has one buddy), then do not pass an array containing a single $uid to activity_get_activity.

This patch does all of the above, the access checks and puts in:
$activities = activity_get_activity((empty($uids) ? $user->uid : $uids), NULL, 20);
to make sure an empty array is not passed.

sirkitree’s picture

sirkitree commented
StatusFileSize
new buddylistactivity_definition_5.patch4.43 KB

ok so this extra target is not needed at all. what the hell was i thinking?

WISEOZ’s picture

WISEOZ commented

I'm only seeing all activity or my activity at /activity and the buddylist activity block seems to appear blank. Is this the patch I need? If so, I don't see buddylistactivity.module in the contrib folder for the 5.x-3.0-beta version. Am I missing something?

sirkitree’s picture

sirkitree commented

this is for the dev version of the module and not in beta. there have been a few supported modules that were updated for the new API and I've not yet rolled another release. please feel free to try it out. I'm using it on a site and it's working pretty well so far. thought taking it live will be the REAL test ;)

WISEOZ’s picture

WISEOZ commented

I upgraded to the .dev version as suggested and applied both the PostgreSQL patch and this patch. I saved the token settings as well even though their are no buddylist tokens listed. I'm not receiving any errors but the buddylist activity block still only shows node links and no verbiage.

WISEOZ’s picture

WISEOZ commented
StatusFileSize
new activity.PNG33.15 KB

Any update on this issue ...?

Attached is a screen shot of what I am seeing for buddylist related activity (on top) versus all activity (on bottom). For buddylist, I am only seeing node links without the use of tokens. There are also no token settings available for buddylist in the admin settings.

sirkitree’s picture

sirkitree commented
StatusFileSize
new Activity Settings Activity Testing.png213.72 KB

you should see something like the following screenshot. if you do not, you may want to check your code again to make sure you are using the latest dev of buddylistactivity.module

WISEOZ’s picture

WISEOZ commented

I installed the latest dev version and I now see the fields to include tokens in the admins screen. I'm still not seeing what I expect to see in the block. I am specifically looking for the block that displays activity for the owner of the page and the users of their buddylist. It seems the block I'm looking at is including all site activity. Can you remind me which block just includes activity for the page owner and the users on their buddylist?

sirkitree’s picture

sirkitree commented

activity.module provides a block for (Activity: All: show all recent activity) and (Activity: Mine: show the current user's activity.)

buddylistactivity.module provides a block for (Activity - My buddies: show activities of current user's buddies.)

mariusooms’s picture

mariusooms commented

In this block: (Activity - My buddies: show activities of current user's buddies) I'm seeing everything I need to be seeing except for the token messages that I've set in the fields for "Tokens for buddylistactivity" under Activity Settings. I'm not sure why this is.

WISEOZ’s picture

WISEOZ commented
StatusFileSize
new buddylistactivity.JPG39.76 KB

Yes! Yes! This is exactly the problem I've been seeing. I've attached another screen shot. The top block represents what the buddylist activity block is showing me. The bottom block represents what the All Activity block is showing me. I am on the latest dev version as of yesterday. Looks like mariusooms and I are experiencing the same problem.

mariusooms’s picture

mariusooms commented

I also discovered some other issues.

1. When fields in Activity Admin Settings are left empty it will still show the red coded 'new' word, but with a blank message behind it.

2. The fields for "Tokens for commentactivity" namely "parent-node-author" and "parent-comment-author" are not saving changes. When I change the token message and submit changes it defaults back to it's original message.

Would you recommend roling back to the beta version instead of the dev?

Kind regards,

Marius

The "My buddies' activities" works, just not the messages like this "userX added userY" and "userX removed userY". Nodes and Commments seem to work correct.

WISEOZ’s picture

WISEOZ commented
Priority: Normal » Critical

I'm raising this issue to critical since it's more than just me experiencing the problem.

I would appreciate any advise as to whether this will be fixed sooner or later. I've got my site going live very shortly and need to make a call as to whether to revert back to the previous version or wait it out.

Thank you!

jaydub’s picture

jaydub commented

working through the buddylist issues at the moment and looks
like some progress will be made. check back for more
updates.

jaydub’s picture

jaydub commented
Version: 5.x-3.x-dev » 5.x-4.x-dev
Component: Code » Activity Contrib

The new 5.4 branch and the new 6.x branch have updated
code for buddylist module integration. Note that you should not test this
out on a production site as many token patterns have changed
and no upgrade functions have been written at this point.

#314433: Activity 6.1 & 5.4

sirkitree’s picture

sirkitree commented
Status: Needs review » Closed (won't fix)

5.x unsupported