Project:Localization server
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I need the ability to review strings a user approved. Today i cannot find this strings by user. Any way to get this info?

Comments

#1

Hm, it is in the database. Look for user_approved in the translation table. Otherwise I am not entirely sure this would be a common need on the main translation interface. What do you think?

#2

If you figure out a user approved their own translations and they are partly not good translated, contain typos, etc you are lost today.

Additional as Manager i don't like to approve my own translations, but i cannot see the user name if i search the DB for suggestions. So i will for sure approve my own translations... i pushed ~200 strings in with import and now i cannot see the other 30 waiting for approval from other people. i have no idea what strings are not mine.

#3

Yeah, displaying usernames (and times) for suggestions pretty much solves this problem right? Also much easier to code. We already have a CNR patch for this: http://drupal.org/node/203809

#4

Hm... How should i find the ~200 strings inside 4000 only one user have translated and i'd like to review after his own approval?

#5

All right. This still does not generate me more time to code this patch, so I put it on my todo list. Ideas on a good user interface for this would be great. I'd expect people to "search for strings suggested by $username" and "strings translated by $username" and "strings translated or suggested by $username" and "strings approved by $username" (if I did not miss anything :). How to encapsulate this into an easy to understand interface and where to put that interface?

#6

Sounds good. I know it will be ready when it's ready... but we need to find this 200 strings very soon... i hope you find some time for this :-)

#7

I suggest we rename this to "Advanced search form" and mark few more issues as duplicates. Then a discussion how this advanced form should look like would be great.

#8

#9

Priority:normal» critical

A user imported Turkish into our German translation server as suggestion for German... we need to search for users feature... and blind DROP specific user translations... *PLEASE*

#10

Looking forward to these patches. We still need quite some UI love there. Also, I wonder how would a turkish translator be able to import stuff to German. I have seen you are using Organic Groups, aren't you?

#11

I'm not sure if kkaefer have installed OG... i don't think so. There is the normal import tab... and then you are able to select every pot file you have and submit this file in every translation. There is no translation verification check build-in, yet. Would be a good idea to add such a language check feature... however it could be circumvented if the language file is not compliant and do not specify the language themself or is named differently, but it could possibly stop some users from importing wrong translation files.

kkaefer removed all the suggestions of this user on DB level for now, but it's a real life issue. I can only approve translations there, but have no shell access or direct DB access on his box.

If we don't have some more administrative features here we need to ask d.o. Infrastructure very often to fix such issues for future in a reasonable time...

#12

Hass, Organic Groups is the permission checker for this, where permissions to import/suggest/translate stuff is limited to group members and admins. I am not going to implement that as it is already done in OG, and OG also provides other features which would be needed by translation groups anyway (eg. discussion of translations, information pages for translators, whatever).

As far as adding user filtering goes, I think you already took more time arguing about it then what it takes to implement it, as long as we keep arguing this issue is not getting further. I see the need and I am in support of user based filtering in the light of experience of people using the tool.

#13

No, OG is no solution here.

How should OG ever prevent against users that are members of German translation group and importing a Turkish translation file? Or do you think German people cannot download a Turkish translation file somewhere and import this into a German translation? This is a human fault... or someone trying to harm your translation.

#14

It would prevent non-members of the German team to import any translation file. It would not prevent German team members to import whatever they like.

Again, this is offtopic on this issue, but feel free to open an issue about detecting the PO file language (if specified in the file), and ask "Are you sure?" questions in cases, when the languages do not match. That's a different issue.

#15

Category:bug report» feature request

I think this is a feature request?

#16

I think this would be a great feature for localize.drupal.org where such accidents can easily happen as well.

#17

So just to summarize, we have a UI problem and a performance/SQL problems here:

I'd expect people to "search for strings suggested by $username" and "strings translated by $username" and "strings translated or suggested by $username" and "strings approved by $username" (if I did not miss anything :). How to encapsulate this into an easy to understand interface and where to put that interface?

And the other issue is performance/SQL building. We currently only filter on the translations themselves. So we have "has suggestions" cached on the translation itself in the DB. If we'd need to look for all child suggestions of the strings then that would be a sub-query for the user. It would also allow us to do a subquery for string matching (currently when you fill in "contains", it does not look at any of the actual suggestions, only the main english string and the one active translation). That could however slow down the code pretty badly. But that is an assumption, not proven by benchmarks. So it can be experimented with for sure.

So we can easily search for "active translations approved by $username" and "active translations submitted by $username", but not any of the suggestions without a subquery.

#18

Status:active» postponed

Given that #570648: Add mass moderations screen for suggestions (+ user filtering) adds a UI to handle suggestions in a grander scale easier, and it unifies filtering among the (now) three screens for listing/editing, it also includes user filtering. Please review that and help get that in. I'm sure translation teams will love the added functionality :)

#19

Status:postponed» fixed

#570648: Add mass moderations screen for suggestions (+ user filtering) was committed and deployed on localize.drupal.org, so now user filtering is on translations and suggestions. Yay! http://localize.drupal.org/node/117

#20

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here