Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.A user without permission to approve translations cannot delete/edit it's own suggestions. This should be changed. I haven't had the approval permission earlier and i wasn't able to delete suggestions with typos :-(.
Comments
Comment #1
hass commentedComment #2
gábor hojtsyTranslation and suggestion editing basically works with saving new translations and suggestions, and you can "edit" your suggestion by adding a new one. It might inded be a good idea to be able to revoke one's suggestion (which would move it out of the waiting queue for a string, but definitely not remove it from the database).
Comment #3
hass commentedI'm not able to remove my own suggestions if i don't have manager permissions... that is not good. Why does it make sense to keep typo strings if i'm sure i can delete my own typos!? But it is more important to get it out of the queue.
Comment #4
gábor hojtsyl10n_server replaces cvs for translations, so we keep the history ourselves per string :)
Comment #5
meba commentedTherefore closing?
Comment #6
hass commentedWhy should a user not able to delete his faulty suggestion? It's like the "Edit" link in this post... that allows me to correct typos and so on.
Comment #7
gábor hojtsy@hass: much like how the edit link creates a new revision, suggestions are archived, so you can 'edit' a suggestion which marks the older one archived and creates a new one. That is exactly how creating a new revision of a node works with the edit link on nodes (and revisions turned on). The reason we are enforcing "revisions" here is to keep history. This tool is to replace a version control system for translations, so we replicate that funtionality.
Comment #8
hass commentedThis must be a misunderstanding... we need to archive *approved* strings, not the 10 wrong suggestions not yet approved and may never ever been approved and only waiting for a review... Often I have written a suggestion, saved it and one hour later got a much better idea for this string or decided it is bullshit. Than I wished to be able to remove the old cruft to replace it with my better idea. If users are able to do this - this have stopped poisoning the translatable review queue!
Always keep in mind that this is partly one of a very few reasons why we have taken down the German translation server. We have never been able to review all strings and all was full of bad strings noone was able to handle. Many people suggested 5 strings for the same English string and it was not manageable at all... additional we haven't had the "mark string as golden" feature what made people to suggest for strings we do not need any suggestions for... looking back - this may be the main reason why the server was taken down.
Comment #9
gábor hojtsy@hass: we can possibly let people "revoke" (aka archive) their suggestions, so that moderators do not need to go through over items which people revoked. But as said above, previous suggestions are archived.
Comment #10
hass commentedIf we see that the archived suggestion have never been approved... that's fine. It would also be great to be able to see the history of suggestions (approved and unapproved) without taking a look to the database directly...
Comment #11
gábor hojtsyYeah, old suggestions (even if never approved) might help you get inspired for fixing up some bad string. :) Reviewing them is not yet part of the UI as we did not figure out a good way to present them without cluttering up the user interface.
Comment #12
gábor hojtsy#652460: Add permission to allow declining own translations seems to be a duplicate and has a patch.