CSS Class problems with this module
| Project: | Bookmarks with login reminders |
| Version: | 5.x-1.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | sanduhrs |
| Status: | closed |
Jump to:
Hello,
I'd like to report a bug in this module that apparently affects the way class names are generated for the lists containing the "quick link" and "manage" links, causing those items to be "un-theme-able". In an older release of this module thoses classes were named "bookmarks_%linkname", (i.e. bookmarks_quick_link) and were thus accessible via CSS. Now, the classes only have numbers in it (c.f. code snippet below, line #13 oder #14) making it impossible to access them via CSS, as class names starting with or containing only out of numbers are not within the scope of CSS specifictions.
I'd also like to mention that the recycle bin has been gone, and that's because apparently the HTML code for the bin image to appear has been removed (c.f. line #7). The hyperlink there has no clickable content and therefore remains invisible.
Regards
Jaganaud
#1
#2 admin's bookmarks
#3
#4
#5
-
#6
-
#7 Blöcke
#8
#9
#10
#11
#12
-
#13
- quick link
- manage
#15
#14
#16
#1
Please use code tags when posting code.
You may change the lines 124-142 as follows:
<?php$links = array(
array(
'title' => t('quick link'),
'href' => "bookmarks2/$user->uid/add/quick",
'attributes' => array(
'title' => t('Bookmark the current page.'),
'class' => 'bookmarks2_quick_link',
),
'query' => 'title='. urlencode(drupal_get_title()),
),
array(
'title' => t('manage'),
'href' => "bookmarks2/$user->uid",
'attributes' => array(
'title' => t('Manage your bookmarks.'),
'class' => 'bookmarks2_manage',
),
),
);
?>
I will post a patch later this week, when I have access to cvs again.
vg
#2
Sorry, forgot about that.
Fixed and commited.
thanks.
#3
Automatically closed -- issue fixed for two weeks with no activity.