I just upgraded to 1.0 and everything seems fine with one exception. The admin theme setting I apply on the settings page is not being honored. No matter I what I set the admin theme to, it uses the main theme that the subdomain uses. I switched back to rc4 and the issue went away. Of course I made sure to clear the cache whenever I made the switch.

Any ideas where I should start looking?

Comments

mrichar1’s picture

mrichar1 commented
Component: - Domain Conf » - Domain Theme

After digging around a little bit it seems like this might be related to the recent changes to domain_theme. Beyond that I am a little lost.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Try setting the weight of Domain Theme to -5. Look under the 'Theme settings' on Admin > Build > Domains.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

The weighting trick should work. But odd behaviors are, IMO, the fault of the Drupal core.

system.module runs this check in system_menu():

    if (arg(0) == 'admin') {
      global $custom_theme;
      $custom_theme = variable_get('admin_theme', '0');
      drupal_add_css(drupal_get_path('module', 'system') .'/admin.css', 'module');
    }

Which, in effect, will cancel out any custom admin theme. Changing the weight of the Domain Theme module will let it act after the system module. Note that this code also prevents "use domain default theme" from working properly, as this routine resets the $custom_theme variable.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Closed (fixed)