Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I just updated to the 2008-02-11 snapshot and noticed a problem with video nodes. Whenever a video node is display we get both the video player and image thumbnail displayed. Shouldn't we display only one of these depending on whether we are viewing the node or node/$nid/play?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | preview_play.patch | 1.19 KB | bkat |
Comments
Comment #1
vhmauery commentedYes, that would be ideal. I never got around to fixing that one. Could you post a patch?
Comment #2
bkat commentedHere's a quick patch that I came up with. What I did was write function that returns true if we are playing a video based on the path ending in "/play". I borrowed this idea from acidfree's _path_match_function.
Then in video_module, I only generate node->content['video_player'] if the function returns true.
Correspondingly, in video_image_module, I only generate the preview if we're not playing the video.
You can take a look at how this function by going to http://womensfooty.com/bogus
If you have any suggestions for improving the patch, let me know.
Comment #3
bkat commentedchanging status to see if anyone can look at the patch
Comment #4
fax8 commentedactually with the latest version we don't use the /play bit anymore. So.. we should just hide the thumbnail on full node display.
Comment #5
fax8 commentedI should have fixed this one. As we no more provide the node/XXX/play handler and always play in node view I completely removed the in body thumbnail display logic.
Comment #6
bkat commentedThe thing I don't like about the current version (2008-02-18 snapshot) is that by eliminating the thumbnail display, the video starts playing (at least with flash) when the node is displayed.
I vastly prefer having the user click to play the video.
Can we at least change autoPlay:true to autoPlay:false and add loop:false to theme_video_play_flash() ?
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.