Drupal 6?

Hi,

I've updated my image_filter module to work with Drupal 6, and I've attached a patch created against the current CVS HEAD. It is not perfect, as I have not managed to map all parameters into the new URL syntax, and it uses node_load instead of a custom SQL query to find the image data, which is probably not the most efficient way of doing things. The advantage is that using node_load insulates this module from the changes to the file storage system that have come along with Drupal 6 and broken the old SQL.

The only other trick is remembering to add a image_filter_theme function that declares a image_inline_img theme hook.

I hope this helps.

Cheers,
Andy J.

tested the patch successfully.

node_load means that img->title isn't set properly.

updated patch attached.

I did a conversion myself, very similar, only the query was different. I use joins...

    $result = db_query(db_rewrite_sql("SELECT n.nid, n.title, i.image_size, f.filepath FROM {node} n INNER JOIN {image} i ON i.nid = n.nid INNER JOIN {files} f ON f.fid = i.fid WHERE n.status = 1 AND n.nid = %d" . (strlen($size) != 0 ? " AND i.image_size IN ('" . db_escape_string($size) ."','_original')" : '')), $match[1]);

which is the best fastest?

Bert

Doesn't apply against CVS head release from October 21, 2007.

patching file image_filter.info
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file image_filter.info.rej
patching file image_filter.module

Repeat does get one hunk to succeed:

1 out of 1 hunk FAILED -- saving rejects to file image_filter.info.rej
patching file image_filter.module
Reversed (or previously applied) patch detected!  Assume -R? [n] n
Apply anyway? [n] y
Hunk #1 FAILED at 4.
Hunk #2 FAILED at 129.
Hunk #3 succeeded at 222 with fuzz 1 (offset 18 lines).
Hunk #4 FAILED at 252.
3 out of 4 hunks FAILED -- saving rejects to file image_filter.module.rej

This patch works for me. I noted this module was abandoned so have adopted it and committed this into HEAD. The nightly build should pick it up so please test and confirm.

No complaints from the RC so marking fixed.