Links show up incorrect for multiple categories

Sunil Mohan - February 12, 2008 - 10:34
Project:Service links
Version:5.x-1.1
Component:Code
Category:bug report
Priority:normal
Assigned:apsivam
Status:closed
Description

Problem:
When a node has multiple categories assigned, service links do not show up properly.

Steps to reproduce:
1) Create a node and assign multiple categories (about 4) to it.
2) Configure service links module and set the configuration such that services links should show up for one of the above categories.

Actual results:
Service links do not show up on the created node unless all the categories of the node are selected to be displayed by the service links module in the configuration.

Expected results:
Service links should show up for the node if any of the configured categories matches any of the node categories.

Problem (obviously) seems to be in the function that decides whether or not to show the service links: _service_links_show.

The attached patch fixed the problem for me.

AttachmentSize
service_links_multiple_categories_matching.patch871 bytes

#1

apsivam - February 26, 2008 - 17:02
Assigned to:Anonymous» apsivam
Status:patch (code needs review)» fixed

patch applied to HEAD

#2

omnyx - March 10, 2008 - 00:55

can someone explain me how to apply this patch?

Do I just change the lines in the .module file - i.e. take out the one with - and add the ones with + next to them?

#3

peterpoe - March 12, 2008 - 14:43

You can read the Patches section of the handbook for instructions: http://drupal.org/patch

You can also apply the patches manually that way, but the point of patches is precisely to avoid manual updating :)

#4

Anonymous (not verified) - March 26, 2008 - 14:52
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.