This patch changes adminrole so that permissions are also set when the admin settings form for Admin Role is submitted. It also adds to documentation of functions and in the interface, and tidies up whitespace for better code readability.

CommentFileSizeAuthor
#2 221124.patch2.96 KBBevan
#1 adminrole_update_perms_on_settings_submit_v2.patch1.32 KBJacobSingh
adminrole_update_perms_on_settings_submit.patch2.54 KBBevan

Comments

JacobSingh’s picture

JacobSingh commented
StatusFileSize
new adminrole_update_perms_on_settings_submit_v2.patch1.32 KB

Thanks Bevan!

I noticed one small bug though, you were referencing the wrong form_id when setting the callback.

Re-rolled the patch.

One problem though is that when switching roles, you really end up with two admins. We should probably remove the previous role's perms when a switch is made... what do you think?

Bevan’s picture

Bevan commented
StatusFileSize
new 221124.patch2.96 KB

Ah! Yes. I later realized that I had not tested it properly and my patch wasn't in fact even working!

I rerolled my patch with the one functional difference between your and my patches: 

-  if (in_array($form_id, array('system_modules', 'adminrole_update_perms'))) {
+  if (in_array($form_id, array('system_modules', 'adminrole_admin_settings'))) {

In your patch you had reverted a bunch of minor documentation and whitespace changes that I made.

JacobSingh’s picture

JacobSingh commented
Status: Needs review » Patch (to be ported)

Thanks! Finally in.

JacobSingh’s picture

JacobSingh commented
Status: Patch (to be ported) » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.