I just saw they got bumped to D7. This is good, but I'd prefer it more fine-grained if possible.

Something like:

D6 pending bugs
D6 criticals
D7 patch queue
D7 patches to review

So it's easy to keep an eye on post-release D6 issues without having to use bookmarks or any of that crazy stuff.

CommentFileSizeAuthor
#15 221510-contributors-block-15.patch11.4 KBmikey_p
#15 contributor_links.png66.9 KBmikey_p
#14 221510-contributors-block-14.patch11.43 KBmikey_p
#12 221510-contributors-block-12.patch11.43 KBmikey_p
#11 221510-contributors-block-11.patch11.37 KBmikey_p
#9 221510-contributors-block.patch10.56 KBcatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
Title: Contributor links » D6/7 issues Contributor links

Also, the counts still refer to D6 queues (click on "0 criticals"). I thought this was cron not having run yet when I originally posted.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

That's goverened by drupalorg.module (in contrib HEAD). Just committed this change: http://cvs.drupal.org/viewcvs/drupal/contributions/modules/drupalorg/dru... Note that drupalorg module is also limited to tracking counts for only one set of release node numbers, so the mixed Drupal 7 + 6 counting needs to be implemented as well here, not only a change of links in the block.

drupalorg module still needs to be cvs updated on drupal.org.

gerhard killesreiter’s picture

gerhard killesreiter commented

cvs up done

catch’s picture

catch
he/him
Primary language English
commented

Ooh new shiny D7 counts. Thanks! Will leave open for D6 bug counts if people think it's a good idea.

catch’s picture

catch
he/him
Primary language English
commented
Title: D6/7 issues Contributor links » Show Drupal 6 critical issues in contributors block
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I think this is indeed a good idea but does need some feature development.

catch’s picture

catch
he/him
Primary language English
commented
Title: Show Drupal 6 critical issues in contributors block » Update contributors block for 8.x (and minor changes)
Project: Drupal.org site moderators » Drupal.org customizations
Version: » 6.x-3.x-dev
Component: Site organization » Code
Category: feature » task
Priority: Normal » Major

Time to do this again.

Apart from bumping to 8.x, I'd propose the following changes:

1. Include 'Patch (to be ported)' in the issue listings - this applies to 7.x security patches being forward ported to 8.x, and 8.x backports to 7.x - both currently get a bit hidden when set to that status.

2. If it's easy, have a single link to 8.x + 7.x critical issues (so we know how many criticals total against both versions), if not, add a new line for 7.x criticals so that these can be easily tracked.

I haven't done any d.o. patches (or at least not for a very long time), but if no-one jumps on this I'll try to figure it out.

catch’s picture

catch
he/him
Primary language English
commented

Arguably D7 major issues could be added here as well.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 221510-contributors-block.patch10.56 KB

Here's an initial patch. I don't have d.o testing profile set up locally, so no testing beyond php -l.

I went for separate links for each version, because that's a lot simpler - and running a couple of extra queries that are the same structure is less of a change than making = an IN(). Also I'm not convinced combined issue lists will be that helpful compared to two separate ones.

mikey_p’s picture

mikey_p commented

Would it make sense to make the D7 links available as a separate block? Maybe even add a block for D6 links as well, but keep the main contributor links block for D8?

mikey_p’s picture

mikey_p commented
StatusFileSize
new 221510-contributors-block-11.patch11.37 KB

Fixed a few variable names in this chunk:

  $counts_pending = $counts[DRUPALORG_CORE_VERSION_TID]['Pending bugs'];
  $counts_critical_stable = $counts[DRUPALORG_CORE_VERSION_TID]['Critical issues'];
  $counts_major_stable = $counts[DRUPALORG_CORE_VERSION_TID]['Major issues'];
  $counts_queue = $counts[DRUPALORG_CORE_VERSION_TID]['Patch queue'];
  $counts_review = $counts[DRUPALORG_CORE_VERSION_TID]['Patches to review'];
  $counts_critical = $counts[DRUPALORG_CORE_DEVELOPMENT_VERSION_TID]['Critical issues'];
  $counts_major = $counts[DRUPALORG_CORE_DEVELOPMENT_VERSION_TID]['Major issues'];

Otherwise looks good to me, unless anyone has any comments about breaking 7 issues out into a separate block (just the links under 'queues').

mikey_p’s picture

mikey_p commented
StatusFileSize
new 221510-contributors-block-12.patch11.43 KB

Whoops, looking at that, a couple of the contants are wrong still.

This renames the contants which don't seemed to be used anywhere else in drupalorg or any of it's modules (I greped through bzr checkout).

Also applied this on http://project.redesign.devdrupal.org/ but that DB needs refreshed since it doesn't have the proper term for 8.x in it yet.

catch’s picture

catch
he/him
Primary language English
commented

Separate block - I'm not sure either way.

I kind of want them in the same block, because we have continual confusion on the core development process, and people who are new and want to track D7 issues, may not realise that all the work is being done against D8 for those issues too. Too many times with D7, I forgot to filter on D7 issues and discovered a load of working being done in D6 issues that should've been tracked against D7 (including completely duplicate issues because they were duplicate across the two versions). That's a harder problem to solve than this block though.

mikey_p’s picture

mikey_p commented
Status: Needs review » Needs work
StatusFileSize
new 221510-contributors-block-14.patch11.43 KB 
+++ b/drupalorg_project/drupalorg_project.moduleundefined
@@ -4,16 +4,26 @@
+define('DRUPALORG_CORE_DEVELOPMENT_VERSION_NAME', '8x');

Changed this to 8.x

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review
StatusFileSize
new contributor_links.png66.9 KB
new 221510-contributors-block-15.patch11.4 KB

Caught one constant hiding in a loop.

contributor_links.png

mikey_p’s picture

mikey_p commented
Issue tags: +needs drupal.org deployment

Committed, tagging for deployment.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed
Issue tags: -needs drupal.org deployment

Deployed.

catch’s picture

catch
he/him
Primary language English
commented

Woo! Thanks mikey_p and drumm for fixing this up!

catch’s picture

catch
he/him
Primary language English
commented

Followup issue for those interested: #1155604: Move pending bugs below patches in contributors block.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 24a8f54 on 6.x-3.x, 7.x-3.x-dev by mikey_p: 
    Issue #221510: Update contributors block for 8.x (and minor changes)