Inconsistent Textimage heights

I've been working on this and thing I've come up with a solution (although this is my very first attempt at fixing anything at drupal.org, so please forgive any newbiness). The root of this issue is due to due to the inconsistent behavior of php's imagettfbbox() function, which you can read loads about at: http://us.php.net/imagettfbbox

The problem boils down to two issues:

1. The height of the image depends on the presence of ascenders or descenders in the text - so for example "acorn", "Box", and "Any" would all have different heights.
2. The baseline of the text works out to be the lowest point of any letter there, so if you had an image of "acorn" and an image of "any" next to each other, they would look misaligned.

My solution involves a few patches to textimage_text_to_image() in textimage.module (I'm working with 6.x-2.x-dev):

1. After $bbox=... around like 658 I've added:
     // Get dimensions of a generic, one-line string using all chars, just in case something has a crazy height.
  $bboxblank = imagettfbbox($fontsize, 0, $font, "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890");
2. Next, 6 lines down, I've changed the $height... line to:
       if($bbox[1] < $fontsize) { // If the text is one line, use our generic box.
        $height = $bboxblank[3] - $bboxblank[5];
    }
    else {
    $height = $bbox[1] - $bbox[7]; // Else, do it the original way.
    }
3. Finally, near the bottom of the function (line 726 after the additions above), I've changed $ty... to:
     // If no angle and not wrapped, then calculate the baseline from our generic box.
  if($angle == 0 && $height < $fontsize*2) {
  $ty = -$bboxblank[7] - ((-$bboxblank[7] + $bboxblank[3]) / 2);
  }
  else {
    $ty = -$bbox[7] - ((-$bbox[7] + $bbox[3]) / 2); // Else, use the original method.
  }

I believe these should clear up most of the issues with 0-angle text. I coded them specifically not to mess with any text that's not flat, and also so that they don't break wrapped text. If people could take a look at these and give me some feedback, I'd appreciate it.

A fix for this should be committed within the next few days.

You're the man now dog.

Automatically closed -- issue fixed for 2 weeks with no activity.