just noticed an inconsistency with other modules. When the content is not known you have $content_type and $content_id

small change that will make reading your code easier.

Comments

kbahey’s picture

kbahey commented

No.

eid is entity ID.

An entity can be a node (content) as well as comment and user, which are not content.

GreenJelly’s picture

GreenJelly commented

The reason I mentioned this change is because Taxonomy is under the same circumstance, and they call it "content_id" and "content_title".. that was the consistancy I was mentioning. As stated it is a small change, and doesn't matter much, however I have been actively working with your module as a model of my own, and thats when I saw the difference. In taxonomy, the relationship between content_id and content_title is what defines content. I see all elements displayed to the end user as content, even user accounts, comments, or what ever the next add-on is. Even your own module can be considered content.

BTW; You did good work... I am quite impressed, at every turn of the way I have seen how you eloquently deal with the code. On a few accounts I thought I saw a problem, only to realize how you did it was quite cool!

GreenJelly’s picture

GreenJelly commented

Ohh I wanted to have a private conversation with you about my module. I dont want it to be public, and I would prefer a discussion in a private chat, so that we may discuss and share ideas.

pomliane’s picture

pomliane commented
Status: Active » Closed (won't fix)

This version of Flag content is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.