404 pages and containers

diabloview - February 14, 2008 - 21:41
Project:Drupal
Version:7.x-dev
Component:forum.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:patch (code needs work)
Description

This happens on Drupal.org as well. Normally when you go to a non-existent node, you get a 404 error page, either the default or custom if you have set one up. What happens when you go to a non existent node that shares the first digits with a container is another matter. When you do this, you get an empty forum. So if the path to a container is: /node/615 , any node that begins with the numbers 615 will come up with an empty forum instead of the 404 page it should display.
node/6152
node/6157
node/61567399458
all these will show an empty forum.

#1

Liam McDermott - February 19, 2008 - 17:14

I wasn't able to reproduce this with Drupal 5 (I get a 404 error, as expected). Have you tried this on a new install of Drupal with no contributed modules? It could be some wayward module that's causing the problem.

#2

diabloview - February 19, 2008 - 20:40

I have tried it on a fresh install. It happens on this very web site too, and Gallery 2's web site. I added all the 5's after clicking on a forum container. Try these links to see what you get, it's an empty forum, not a 404 page.

gallery.menalto.com/forum/1155555555

drupal.org/forum/85555555555555

#3

Bart Jansens - February 25, 2008 - 10:36

I think the URLs in the original example are wrong. Forum module generates empty forum pages for anything below forum/. This is indeed a bug. This happens a lot if you use pathauto and then delete a node.

Attached is a patch which i am using on my site. But this problem seems to exist in D6 as well, so maybe we should have it fixed in head first and then backport?

AttachmentSize
forum-send-404-instead-of-generating-empty-pages.patch981 bytes

#4

keith.smith - February 25, 2008 - 14:24
Status:active» patch (code needs work)

Small coding style issue: comments should begin with a capital letter, and end in a period.

#5

Michelle - September 14, 2008 - 21:11
Version:5.5» 7.x-dev

Bumping the version. If it's still a problem, the patch probably needs a reroll.

Michelle

 
 

Drupal is a registered trademark of Dries Buytaert.