function theme_taxonomy_manager_form($form) {
$pager = theme('pager', NULL, TAXONOMY_MANAGER_TREE_PAGE_SIZE, 0);
$tree = drupal_render($form['taxonomy']);
$term_data = drupal_render($form['term_data']);
$top = drupal_render($form);
$output = $top . $pager;
$output .= '

';
$output .= $tree;
$output .= '
';
$output .= $term_data;
$output .= '

';
$output .= '

';
$output .= '

';

return $output;

<<<<< $output .= '

'; >>>>>>
This line should be removed or causes html markup error

I spent 3 hours until I found it :(

CommentFileSizeAuthor
#2 taxonomy_manager.patch412 bytesdavemybes

Comments

vipconsult’s picture

vipconsult commented

Oops
forgot to put the code tags

function theme_taxonomy_manager_form($form) {
  $pager = theme('pager', NULL, TAXONOMY_MANAGER_TREE_PAGE_SIZE, 0);
  $tree = drupal_render($form['taxonomy']);
  $term_data = drupal_render($form['term_data']);
  $top = drupal_render($form);
  $output = $top . $pager;
  $output .= '<div id="taxonomy-manager">';
  $output .= $tree;
  $output .= '<div id="taxonomy-term-data">';
  $output .= $term_data;
  $output .= '</div>';
  $output .= '<div class="clear" />';
  $output .= '</div>';
  
  return $output;



<<<<<  $output .= '<div class="clear" />';  >>>>>>

This line should be removed or causes html markup error

I spent 3 hours until I found it :(

davemybes’s picture

davemybes commented
StatusFileSize
new taxonomy_manager.patch412 bytes

I just noticed this error too. Thanks for finding it and posting here. I am attaching a patch to the -dev version of 2007-11-27 to fix this. Simply adding a closing div statement directly after the opening div will correct it. If you remove that line, it may still break your layout due to floated elements above it. If you are not using Garland, make sure that your stylesheet has a declaration like this:

.clear {
  clear:both;
}

This will clear the floats above, and not break your layout.

Thanks a million to the maintainer of this module - it has saved me hours of work after a client somehow made all terms top level terms! Awesome stuff.

davemybes’s picture

davemybes commented
Title: It has HTML mistake that brakes the layout » Module has HTML mistake that breaks the layout
Status: Active » Needs review
an.droid’s picture

an.droid commented

Very simple and working patch. I think it should be included in the release. But someone need to update it for 1.1 first.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Closed (duplicate)

More recent patch here: #288587: unclosed div breaks page layout in admin form
No one seems to want to commit it though...