Project:Imagemenu
Version:5.x-1.1
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

Three small issues in the xHtml

- name is not a valid attribute (changed to id)
- The Only local images are allowed. tag was not closed
- the OnMouseOver event and OnMouseOut should be written in smallcaps

AttachmentSize
xhtml.patch1.15 KB

Comments

#1

This is a new version that actually works in the crap that M$ churns out.

Had to add an external javascript file, you need to copy that in the modules' folder

AttachmentSize
xhtml.patch 2.48 KB
imagemenu.js_.txt 288 bytes

#2

Sorry I've only just got back to you on this. I don't actively develop for this module any more and so don't get the issue queue emailed to me directly. Thanks for your changes, I'll commit them once I've had a chance to take a look at them.

Thanks,

Pobster

#3

I had the same validation problem with 6.x-1.0 version.
I followed your suggestions and manually changed name/id and small caps for mouseover/mouseout. Now everything works well.
Thank you.

#4

Hi, I don't develop for the 6.x branch - someone kindly offered to take that over for me (I've got a lot on).

I'm sure if you post a 6.x issue in this queue he'll gladly make the changes so the module passes validation. I don't read the 6.x issues and I'm sure he doesn't look at the 5.x ones!

Pobster

nobody click here