Hi

I've started using diff and I really like it, it's perfect for collaborative sites.

But I think it would be better if the module won't use tables to show their results. Using DIVs instead will make easier to theme the module and also will help functionality.

Here is an example of wrong usability in my site:

http://img217.imageshack.us/img217/4545/overflowec1.gif

As you can see, the right cell of the diff table where should be the added lines is overflowing and this can not be fixed using css (max-width can not be used in td elements in css). The issue is caused by too long strings in the original text (links in this case).

Best regards and thanks for developing this great module.

CommentFileSizeAuthor
overflow.gif49.15 KBNoRandom

Comments

moshe weitzman’s picture

moshe weitzman commented

Are you sure there is no remedy for those long strings while still using a table? Can you see what wikipedia does for presenting a diff with those long strings? Thats where we got our current HTML and CSS. Post a few revisions to their sandbox.

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Postponed (maintainer needs more info)
NoRandom’s picture

NoRandom commented

Long time without checking this issue, sorry.

You are right, I've just noticed it reading your answer. Actually this problem can be solved using the css "word-wrap" property. It's not a common tag but long words can be split using it.

Actually, thinking more about the problem I believe your approach of using tables is much better in any case. In my opionion (I'm not a proffesional web developer), using divs for showing tabular data is not the straightforward solution. It will need much more work with the css to get the same visual result and I'm not sure the code would get more readable.

Kind regards.

moshe weitzman’s picture

moshe weitzman commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)