Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a great module and I'm very interested in seeing this upgraded to support Drupal 6. Are there any plans at this time?
Comment | File | Size | Author |
---|---|---|---|
#11 | default_filter_22497_11.patch | 16.95 KB | mikey_p |
#2 | default_filter-head-to-d6compat.patch | 9.35 KB | gdevlugt |
Comments
Comment #1
theemstra CreditAttribution: theemstra commentedI hope!
Comment #2
gdevlugt CreditAttribution: gdevlugt commentedI did a (rather quick) port of the current CVS head version for Drupal 6.
Initial tests seemed to work okay, though further testing probably is wise.
Attached to this comment you'll find the patch needed for the CVS head version for the Drupal 6 port.
Hopefully this will help the developer to release an official Drupal 6 version.
Comment #3
theemstra CreditAttribution: theemstra commentedMe and my friend have seen your patch, and found no bugs....
Suc6!
Greetings,
Thom
(www.gangas.nl)(D6)
Comment #4
dllh CreditAttribution: dllh commentedI'm a bit stretched for time at the moment, but as it appears there's a fair amount of interest in getting this ported, I'll try to review the patch and make a release fairly soon. Thanks!
Comment #5
kylehase CreditAttribution: kylehase commentedThe patch is also working for me on D6.0
Comment #6
VladSavitsky CreditAttribution: VladSavitsky commentedIt works in D6.2
Comment #7
bonobo CreditAttribution: bonobo commentedAny roadmap for committing this to a D6 dev release?
Comment #8
mikey_p CreditAttribution: mikey_p commentedpatching file default_filter.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file default_filter.info.rej
patching file default_filter.install
patching file default_filter.module
Hunk #3 succeeded at 88 (offset 1 line).
Hunk #4 succeeded at 121 (offset 1 line).
Hunk #5 succeeded at 167 (offset 1 line).
Hunk #6 FAILED at 198.
Hunk #7 succeeded at 213 (offset 1 line).
1 out of 7 hunks FAILED -- saving rejects to file default_filter.module.rej
Comment #9
Wolfflow CreditAttribution: Wolfflow commentedsubcribe
Comment #10
ajaysolutions CreditAttribution: ajaysolutions commentedI'm also interested to see this in D6... I'm never any good at applying patches and getting them to work.
Looking forward to it!
Comment #11
mikey_p CreditAttribution: mikey_p commentedThis is a semi-reroll of the patch above (I did most of this by hand instead of copying the patch).
Also, fixed a notice at line 108.
Comment #12
joly CreditAttribution: joly commentedHi,
I am not so good in patching etc.
Is it possible that the patched-module is put in this project, so it can be downloaded?
Greetz, Joly
Comment #13
jeffrey.dalton CreditAttribution: jeffrey.dalton commentedsubscribing
Comment #14
mrbrowny CreditAttribution: mrbrowny commentedI also request this module to be ported to 6.x.
Anyone, please?
Thanks in advance!
Claudio Abraham
(mrbrowny in Drupal)
Argentina
South America
Comment #15
linuxuser CreditAttribution: linuxuser commentedI and a few friends can't wait too for a support with 6.4
Comment #16
theemstra CreditAttribution: theemstra commentedUse Coder:
http://drupal.org/project/coder
Comment #17
mikey_p CreditAttribution: mikey_p commented@gangas: There is no need to use coder, as the patch has already been made, and is available in #11.
@all: I don't plan to post a complete version of the module here because it really isn't ready for release yet, and is intended for the developers of this project, or other developers to review. I may not have completed the port properly, or introduced a new bug, for this reason I would rather only experienced individuals/developers test this, and being able to apply a patch is a reasonable test of experience for that. (If the maintainers of this module feel differently, that is fine, I am just stating my opinion regarding my patch)
Comment #18
kmontySubscribing
Comment #19
mrfelton CreditAttribution: mrfelton commentedI'm in need of this too. I'm the creator and maintainer of several other Drupal modules and I will give this a good look over in the next week or two.
Comment #20
kylehase CreditAttribution: kylehase commentedChanging to a more descriptive title for views that do not display the project name. (eg. http://drupal.org/user/<uid>/track)
Comment #21
dbu CreditAttribution: dbu commentedlooking forward to see this module updated for d6 !
Comment #22
theemstra CreditAttribution: theemstra commentedSo do i!
Comment #23
Anonymous (not verified) CreditAttribution: Anonymous commentedI've tested the patch mikey_p posted (comment #11) on Drupal 6.6 and found it to work.
Comment #24
theemstra CreditAttribution: theemstra commentedOn drupal 6.6 worked for me also!
Comment #25
PixelClever CreditAttribution: PixelClever commentedThe patch works fine.
Comment #26
theemstra CreditAttribution: theemstra commentedWorked here fine also, at my friend also, my neigherbour also!
Comment #27
mikey_p CreditAttribution: mikey_p commentedWhat version should this patch be ported to?
Comment #28
theemstra CreditAttribution: theemstra commentedOopz! Sorry!
Comment #29
mrfelton CreditAttribution: mrfelton commentedJust confirming that the patch works for me too on 6.9
Comment #30
mrfelton CreditAttribution: mrfelton commentedupdate:
I get this on the node edit form.
warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object in /var/www/html/concern-6.x/sites/all/modules/default_filter/default_filter.module on line 203.
Comment #31
Todd Nienkerk CreditAttribution: Todd Nienkerk commentedSubscribing.
Comment #32
mikey_p CreditAttribution: mikey_p commented@mrfelton: Could you put a print_r($form); at the top of the default_filter_form_alter function, before line #203 and then paste the results here?
I'm guessing you have another module modifying the form structure, or a content type with no body. If that is the case I will add a check to see that body_field exists before checking for the 'format' key.
Thanks.
Comment #33
mrfelton CreditAttribution: mrfelton commentedI believe this content type has no body.
Comment #34
mikey_p CreditAttribution: mikey_p commentedI think the better approach here is to move to the Better Formats module for D6 usage. Please see http://drupal.org/project/better_formats.
That module replaces default_filter, filter_default and several others quite nicely, in a way more similar to how Drupal 7 will work.
Comment #35
Todd Nienkerk CreditAttribution: Todd Nienkerk commentedI've been using the patched D6.x version of this module for many, many weeks. Everything works great.
Comment #36
Todd Nienkerk CreditAttribution: Todd Nienkerk commentedRegarding switching to Better Formats (#34), please note it does not allow default filter roles per node type. It only distinguishes between nodes and comments by role.
Comment #37
Todd Nienkerk CreditAttribution: Todd Nienkerk commentedScratch my comment in #36. Better Formats does allow default filters per node type. It can completely replace the Default Filter module.
Comment #38
theemstra CreditAttribution: theemstra commentedSo...
Fixed...?
Comment #39
Todd Nienkerk CreditAttribution: Todd Nienkerk commentedBetter Formats does everything Default Filter does and then some. I'd call this "won't fix."
Comment #40
naught101 CreditAttribution: naught101 commenteddllh: would it be possible for you to put some info on the project page about this decision?
Comment #41
Aleet CreditAttribution: Aleet commentedsubscribe