Download & Extend
Default Filter » Issues

D6 support for Default Filter module

Posted by kylehase on February 16, 2008 at 1:30pm
Project:Default Filter
Version:5.x-2.0
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

This is a great module and I'm very interested in seeing this upgraded to support Drupal 6. Are there any plans at this time?

Login or register to post comments

Comments

#1

Posted by theemstra on February 16, 2008 at 1:36pm

I hope!

#2

Posted by gdevlugt on February 18, 2008 at 9:39pm
Status:active» needs review

I did a (rather quick) port of the current CVS head version for Drupal 6.

Initial tests seemed to work okay, though further testing probably is wise.

Attached to this comment you'll find the patch needed for the CVS head version for the Drupal 6 port.

Hopefully this will help the developer to release an official Drupal 6 version.

AttachmentSize
default_filter-head-to-d6compat.patch 9.35 KB

#3

Posted by theemstra on February 19, 2008 at 6:16pm
Status:needs review» reviewed & tested by the community

Me and my friend have seen your patch, and found no bugs....

Suc6!

Greetings,

Thom

(www.gangas.nl)(D6)

#4

Posted by dllh on February 19, 2008 at 6:55pm

I'm a bit stretched for time at the moment, but as it appears there's a fair amount of interest in getting this ported, I'll try to review the patch and make a release fairly soon. Thanks!

#5

Posted by kylehase on February 20, 2008 at 2:32am

The patch is also working for me on D6.0

#6

Posted by VladSavitsky on June 5, 2008 at 9:24pm

It works in D6.2

#7

Posted by bonobo on July 30, 2008 at 11:49pm

Any roadmap for committing this to a D6 dev release?

#8

Posted by mikey_p on August 12, 2008 at 1:33am
Status:reviewed & tested by the community» needs work

patching file default_filter.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file default_filter.info.rej
patching file default_filter.install
patching file default_filter.module
Hunk #3 succeeded at 88 (offset 1 line).
Hunk #4 succeeded at 121 (offset 1 line).
Hunk #5 succeeded at 167 (offset 1 line).
Hunk #6 FAILED at 198.
Hunk #7 succeeded at 213 (offset 1 line).
1 out of 7 hunks FAILED -- saving rejects to file default_filter.module.rej

#9

Posted by Wolfflow on August 28, 2008 at 9:36pm

subcribe

#10

Posted by ajaysolutions on August 29, 2008 at 1:17pm

I'm also interested to see this in D6... I'm never any good at applying patches and getting them to work.

Looking forward to it!

#11

Posted by mikey_p on August 29, 2008 at 9:33pm
Status:needs work» needs review

This is a semi-reroll of the patch above (I did most of this by hand instead of copying the patch).

Also, fixed a notice at line 108.

AttachmentSize
default_filter_22497_11.patch 16.95 KB

#12

Posted by joly on September 23, 2008 at 11:14am

Hi,

I am not so good in patching etc.
Is it possible that the patched-module is put in this project, so it can be downloaded?

Greetz, Joly

#13

Posted by jeffrey.dalton on September 23, 2008 at 9:23pm

subscribing

#14

Posted by mrbrowny on October 1, 2008 at 1:01am

I also request this module to be ported to 6.x.

Anyone, please?

Thanks in advance!

Claudio Abraham
(mrbrowny in Drupal)
Argentina
South America

#15

Posted by linuxuser on October 3, 2008 at 2:35pm

I and a few friends can't wait too for a support with 6.4

#16

Posted by theemstra on October 17, 2008 at 3:54pm

Use Coder:
http://drupal.org/project/coder

#17

Posted by mikey_p on November 4, 2008 at 8:32pm

@gangas: There is no need to use coder, as the patch has already been made, and is available in #11.

@all: I don't plan to post a complete version of the module here because it really isn't ready for release yet, and is intended for the developers of this project, or other developers to review. I may not have completed the port properly, or introduced a new bug, for this reason I would rather only experienced individuals/developers test this, and being able to apply a patch is a reasonable test of experience for that. (If the maintainers of this module feel differently, that is fine, I am just stating my opinion regarding my patch)

#18

Posted by kmonty on November 20, 2008 at 3:45pm

Subscribing

#19

Posted by mrfelton on November 24, 2008 at 11:33am

I'm in need of this too. I'm the creator and maintainer of several other Drupal modules and I will give this a good look over in the next week or two.

#20

Posted by kylehase on November 25, 2008 at 3:20am
Title:D6 support» D6 support for Default Filter module

Changing to a more descriptive title for views that do not display the project name. (eg. http://drupal.org/user/<uid>/track)

#21

Posted by dbu on November 27, 2008 at 4:44pm

looking forward to see this module updated for d6 !

#22

Posted by theemstra on December 3, 2008 at 7:43pm

So do i!

#23

Posted by Shannon Lucas on December 5, 2008 at 5:02pm

I've tested the patch mikey_p posted (comment #11) on Drupal 6.6 and found it to work.

#24

Posted by theemstra on December 6, 2008 at 8:19pm

On drupal 6.6 worked for me also!

#25

Posted by Aaron Hawkins on January 7, 2009 at 5:01pm
Status:needs review» reviewed & tested by the community

The patch works fine.

#26

Posted by theemstra on January 11, 2009 at 11:25am
Status:reviewed & tested by the community» patch (to be ported)

Worked here fine also, at my friend also, my neigherbour also!

#27

Posted by mikey_p on January 12, 2009 at 4:27am
Status:patch (to be ported)» reviewed & tested by the community

What version should this patch be ported to?

#28

Posted by theemstra on January 12, 2009 at 12:35pm

Oopz! Sorry!

#29

Posted by mrfelton on January 26, 2009 at 2:54pm

Just confirming that the patch works for me too on 6.9

#30

Posted by mrfelton on January 27, 2009 at 10:02am

update:
I get this on the node edit form.

warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object in /var/www/html/concern-6.x/sites/all/modules/default_filter/default_filter.module on line 203.

#31

Posted by Todd Nienkerk on January 29, 2009 at 1:34am

Subscribing.

#32

Posted by mikey_p on February 11, 2009 at 1:03am

@mrfelton: Could you put a print_r($form); at the top of the default_filter_form_alter function, before line #203 and then paste the results here?

I'm guessing you have another module modifying the form structure, or a content type with no body. If that is the case I will add a check to see that body_field exists before checking for the 'format' key.

Thanks.

#33

Posted by mrfelton on February 11, 2009 at 7:46am

I believe this content type has no body.

#34

Posted by mikey_p on March 19, 2009 at 1:42am

I think the better approach here is to move to the Better Formats module for D6 usage. Please see http://drupal.org/project/better_formats.

That module replaces default_filter, filter_default and several others quite nicely, in a way more similar to how Drupal 7 will work.

#35

Posted by Todd Nienkerk on April 23, 2009 at 3:23pm

I've been using the patched D6.x version of this module for many, many weeks. Everything works great.

#36

Posted by Todd Nienkerk on April 23, 2009 at 4:45pm

Regarding switching to Better Formats (#34), please note it does not allow default filter roles per node type. It only distinguishes between nodes and comments by role.

#37

Posted by Todd Nienkerk on April 23, 2009 at 5:04pm

Scratch my comment in #36. Better Formats does allow default filters per node type. It can completely replace the Default Filter module.

#38

Posted by theemstra on May 22, 2009 at 9:14am

So...

Fixed...?

#39

Posted by Todd Nienkerk on June 8, 2009 at 10:40pm
Status:reviewed & tested by the community» closed (won't fix)

Better Formats does everything Default Filter does and then some. I'd call this "won't fix."

#40

Posted by naught101 on June 19, 2009 at 10:49am

dllh: would it be possible for you to put some info on the project page about this decision?

#41

Posted by Ali.T on July 9, 2009 at 6:14pm

subscribe

nobody click here