D6 support for Default Filter module [#222497]

Comment	File	Size	Author
#11	default_filter_22497_11.patch	16.95 KB	mikey_p
#2	default_filter-head-to-d6compat.patch	9.35 KB	gdevlugt

Comment #1

theemstra commented 16 February 2008 at 13:36

I hope!

Log in or register to post comments

Comment #2

gdevlugt commented 18 February 2008 at 21:39

Status:

Active

» Needs review

Status	File	Size
new	default_filter-head-to-d6compat.patch	9.35 KB

I did a (rather quick) port of the current CVS head version for Drupal 6.

Initial tests seemed to work okay, though further testing probably is wise.

Attached to this comment you'll find the patch needed for the CVS head version for the Drupal 6 port.

Hopefully this will help the developer to release an official Drupal 6 version.

Log in or register to post comments

Comment #3

theemstra commented 19 February 2008 at 18:16

Status:

Needs review

» Reviewed & tested by the community

Me and my friend have seen your patch, and found no bugs....

Suc6!

Greetings,

Thom

(www.gangas.nl)(D6)

Log in or register to post comments

Comment #4

dllh commented 19 February 2008 at 18:55

I'm a bit stretched for time at the moment, but as it appears there's a fair amount of interest in getting this ported, I'll try to review the patch and make a release fairly soon. Thanks!

Log in or register to post comments

Comment #5

kylehase commented 20 February 2008 at 02:32

The patch is also working for me on D6.0

Log in or register to post comments

Comment #6

vladsavitsky commented 5 June 2008 at 21:24

It works in D6.2

Log in or register to post comments

Comment #7

bonobo commented 30 July 2008 at 23:49

Any roadmap for committing this to a D6 dev release?

Log in or register to post comments

Comment #8

mikey_p commented 12 August 2008 at 01:33

Status:

Reviewed & tested by the community

» Needs work

patching file default_filter.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file default_filter.info.rej
patching file default_filter.install
patching file default_filter.module
Hunk #3 succeeded at 88 (offset 1 line).
Hunk #4 succeeded at 121 (offset 1 line).
Hunk #5 succeeded at 167 (offset 1 line).
Hunk #6 FAILED at 198.
Hunk #7 succeeded at 213 (offset 1 line).
1 out of 7 hunks FAILED -- saving rejects to file default_filter.module.rej

Log in or register to post comments

Comment #9

Wolfflow commented 28 August 2008 at 21:36

subcribe

Log in or register to post comments

Comment #10

ajaysolutions commented 29 August 2008 at 13:17

I'm also interested to see this in D6... I'm never any good at applying patches and getting them to work.

Looking forward to it!

Log in or register to post comments

Comment #11

mikey_p commented 29 August 2008 at 21:33

Status:

Needs work

» Needs review

Status	File	Size
new	default_filter_22497_11.patch	16.95 KB

This is a semi-reroll of the patch above (I did most of this by hand instead of copying the patch).

Also, fixed a notice at line 108.

Log in or register to post comments

Comment #12

joly commented 23 September 2008 at 11:14

Hi,

I am not so good in patching etc.
Is it possible that the patched-module is put in this project, so it can be downloaded?

Greetz, Joly

Log in or register to post comments

Comment #13

jeffrey.dalton commented 23 September 2008 at 21:23

subscribing

Log in or register to post comments

Comment #14

mrbrowny commented 1 October 2008 at 01:01

I also request this module to be ported to 6.x.

Anyone, please?

Thanks in advance!

Claudio Abraham
(mrbrowny in Drupal)
Argentina
South America

Log in or register to post comments

Comment #15

linuxuser commented 3 October 2008 at 14:35

I and a few friends can't wait too for a support with 6.4

Log in or register to post comments

Comment #16

theemstra commented 17 October 2008 at 15:54

Use Coder:
http://drupal.org/project/coder

Log in or register to post comments

Comment #17

mikey_p commented 4 November 2008 at 20:32

@gangas: There is no need to use coder, as the patch has already been made, and is available in #11.

@all: I don't plan to post a complete version of the module here because it really isn't ready for release yet, and is intended for the developers of this project, or other developers to review. I may not have completed the port properly, or introduced a new bug, for this reason I would rather only experienced individuals/developers test this, and being able to apply a patch is a reasonable test of experience for that. (If the maintainers of this module feel differently, that is fine, I am just stating my opinion regarding my patch)

Log in or register to post comments

Comment #18

kmonty

He/Him

Berlin, DE + SF, CA

commented 20 November 2008 at 15:45

Subscribing

Log in or register to post comments

Comment #19

mrfelton commented 24 November 2008 at 11:33

I'm in need of this too. I'm the creator and maintainer of several other Drupal modules and I will give this a good look over in the next week or two.

Log in or register to post comments

Comment #20

kylehase commented 25 November 2008 at 03:20

Title:

D6 support

» D6 support for Default Filter module

Changing to a more descriptive title for views that do not display the project name. (eg. http://drupal.org/user/<uid>/track)

Log in or register to post comments

Comment #21

dbu commented 27 November 2008 at 16:44

looking forward to see this module updated for d6 !

Log in or register to post comments

Comment #22

theemstra commented 3 December 2008 at 19:43

So do i!

Log in or register to post comments

Comment #23

Anonymous (not verified) commented 5 December 2008 at 17:02

I've tested the patch mikey_p posted (comment #11) on Drupal 6.6 and found it to work.

Log in or register to post comments

Comment #24

theemstra commented 6 December 2008 at 20:19

On drupal 6.6 worked for me also!

Log in or register to post comments

Comment #25

PixelClever commented 7 January 2009 at 17:01

Status:

Needs review

» Reviewed & tested by the community

The patch works fine.

Log in or register to post comments

Comment #26

theemstra commented 11 January 2009 at 11:25

Status:

Reviewed & tested by the community

» Patch (to be ported)

Worked here fine also, at my friend also, my neigherbour also!

Log in or register to post comments

Comment #27

mikey_p commented 12 January 2009 at 04:27

Status:

Patch (to be ported)

» Reviewed & tested by the community

What version should this patch be ported to?

Log in or register to post comments

Comment #28

theemstra commented 12 January 2009 at 12:35

Oopz! Sorry!

Log in or register to post comments

Comment #29

mrfelton commented 26 January 2009 at 14:54

Just confirming that the patch works for me too on 6.9

Log in or register to post comments

Comment #30

mrfelton commented 27 January 2009 at 10:02

update:
I get this on the node edit form.

warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object in /var/www/html/concern-6.x/sites/all/modules/default_filter/default_filter.module on line 203.

Log in or register to post comments

Comment #31

todd nienkerk commented 29 January 2009 at 01:34

Subscribing.

Log in or register to post comments

Comment #32

mikey_p commented 11 February 2009 at 01:03

@mrfelton: Could you put a print_r($form); at the top of the default_filter_form_alter function, before line #203 and then paste the results here?

I'm guessing you have another module modifying the form structure, or a content type with no body. If that is the case I will add a check to see that body_field exists before checking for the 'format' key.

Thanks.

Log in or register to post comments

Comment #33

mrfelton commented 11 February 2009 at 07:46

I believe this content type has no body.

Log in or register to post comments

Comment #34

mikey_p commented 19 March 2009 at 01:42

I think the better approach here is to move to the Better Formats module for D6 usage. Please see http://drupal.org/project/better_formats.

That module replaces default_filter, filter_default and several others quite nicely, in a way more similar to how Drupal 7 will work.

Log in or register to post comments

Comment #35

todd nienkerk commented 23 April 2009 at 15:23

I've been using the patched D6.x version of this module for many, many weeks. Everything works great.

Log in or register to post comments

Comment #36

todd nienkerk commented 23 April 2009 at 16:45

Regarding switching to Better Formats (#34), please note it does not allow default filter roles per node type. It only distinguishes between nodes and comments by role.