D6 support for Default Filter module

I hope!

I did a (rather quick) port of the current CVS head version for Drupal 6.

Initial tests seemed to work okay, though further testing probably is wise.

Attached to this comment you'll find the patch needed for the CVS head version for the Drupal 6 port.

Hopefully this will help the developer to release an official Drupal 6 version.

Me and my friend have seen your patch, and found no bugs....

Suc6!

Greetings,

Thom

(www.gangas.nl)(D6)

I'm a bit stretched for time at the moment, but as it appears there's a fair amount of interest in getting this ported, I'll try to review the patch and make a release fairly soon. Thanks!

The patch is also working for me on D6.0

It works in D6.2

Any roadmap for committing this to a D6 dev release?

patching file default_filter.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file default_filter.info.rej
patching file default_filter.install
patching file default_filter.module
Hunk #3 succeeded at 88 (offset 1 line).
Hunk #4 succeeded at 121 (offset 1 line).
Hunk #5 succeeded at 167 (offset 1 line).
Hunk #6 FAILED at 198.
Hunk #7 succeeded at 213 (offset 1 line).
1 out of 7 hunks FAILED -- saving rejects to file default_filter.module.rej

subcribe

I'm also interested to see this in D6... I'm never any good at applying patches and getting them to work.

Looking forward to it!

This is a semi-reroll of the patch above (I did most of this by hand instead of copying the patch).

Also, fixed a notice at line 108.

Hi,

I am not so good in patching etc.
Is it possible that the patched-module is put in this project, so it can be downloaded?

Greetz, Joly

subscribing

I also request this module to be ported to 6.x.

Anyone, please?

Thanks in advance!

Claudio Abraham
(mrbrowny in Drupal)
Argentina
South America

I and a few friends can't wait too for a support with 6.4

Use Coder:
http://drupal.org/project/coder

@gangas: There is no need to use coder, as the patch has already been made, and is available in #11.

@all: I don't plan to post a complete version of the module here because it really isn't ready for release yet, and is intended for the developers of this project, or other developers to review. I may not have completed the port properly, or introduced a new bug, for this reason I would rather only experienced individuals/developers test this, and being able to apply a patch is a reasonable test of experience for that. (If the maintainers of this module feel differently, that is fine, I am just stating my opinion regarding my patch)

Subscribing

I'm in need of this too. I'm the creator and maintainer of several other Drupal modules and I will give this a good look over in the next week or two.

Changing to a more descriptive title for views that do not display the project name. (eg. http://drupal.org/user/<uid>/track)

looking forward to see this module updated for d6 !

So do i!

I've tested the patch mikey_p posted (comment #11) on Drupal 6.6 and found it to work.

On drupal 6.6 worked for me also!

The patch works fine.

Worked here fine also, at my friend also, my neigherbour also!

What version should this patch be ported to?

Oopz! Sorry!

Just confirming that the patch works for me too on 6.9

update:
I get this on the node edit form.

warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object in /var/www/html/concern-6.x/sites/all/modules/default_filter/default_filter.module on line 203.

Subscribing.

@mrfelton: Could you put a print_r($form); at the top of the default_filter_form_alter function, before line #203 and then paste the results here?

I'm guessing you have another module modifying the form structure, or a content type with no body. If that is the case I will add a check to see that body_field exists before checking for the 'format' key.

Thanks.

I believe this content type has no body.

I think the better approach here is to move to the Better Formats module for D6 usage. Please see http://drupal.org/project/better_formats.

That module replaces default_filter, filter_default and several others quite nicely, in a way more similar to how Drupal 7 will work.

I've been using the patched D6.x version of this module for many, many weeks. Everything works great.

Regarding switching to Better Formats (#34), please note it does not allow default filter roles per node type. It only distinguishes between nodes and comments by role.

Scratch my comment in #36. Better Formats does allow default filters per node type. It can completely replace the Default Filter module.

So...

Fixed...?

Better Formats does everything Default Filter does and then some. I'd call this "won't fix."

dllh: would it be possible for you to put some info on the project page about this decision?

subscribe