I'm trying to separate the commitlog. Add them to the menu system with path alias.

[MENU]
commit logs
--core
--modules

commitlog?repos=1 -> git/core
commitlog?repos=2 -> git/modules

This is not working however, so I wonder of course what causes this...?

CommentFileSizeAuthor
#4 url_alias_with_query.patch952 bytesboombatower

Comments

morphir’s picture

I dunno if this the cause of the menu system.

It works when I add the full url like:

http://einit.org/commitlog?repos=1

but not with

commitlog?repos=1

neither with

git/core

hmm...

morphir’s picture

the path alias that I create is not valid!

Can anyone confirm this by visiting admin/build/path and add a alias for their repo. Please.

jpetso’s picture

Project: Version Control API -- Git backend » Version Control API
Version: 5.x-1.2 » 5.x-1.0
Component: Code » Commit Log

I would guess that the menu system cannot do REQUEST parameters, which would be the reason why the path alias doesn't work. Don't know what should be changed in order to create aliasable URLs without the need for REQUEST parameters... an add-on module that generates path aliases like Views does for its views? an alternative way to specify parameters, like "commitlog/repos/1/path/my%2fproject%2fpath"? hm.

Anyways, this is an issue for Commit Log rather than the Git backend.

boombatower’s picture

Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new952 bytes

The problem lies in the url alias system. It attempts to find a handler for the entire string commitlog?repos=1 instead of the desired commitlog.

I wrote a simple patch that will correct this and made a post in the core issue queue http://drupal.org/node/225112. This will fix the problem for all such urls for any module so probably better than coming up with an alternate format.

chx’s picture

Status: Needs review » Closed (won't fix)

Aliases only work for Drupal paths not for full URLs.