Hi,

this doesnt seem to be the regular "white page of death" problem I think.

I had a working 5.x.1.6 version installed with revenue sharing enabled, everything worked like a charm (User1 and Profile Field were correctly configured).

Installed the new version, enabled Adsense revenue sharing basic.

Effect:
- The admin/settings/adsense is blank, cant configure anything
- "No Google Adsense client ID choosing module is enabled. Please check your settings." showes up to anonymous visitors on the front page

CommentFileSizeAuthor
#5 adsense-no_id_choosing_module_fix.patch349 bytesmustafau

Comments

kbahey’s picture

kbahey commented
Status: Active » Postponed (maintainer needs more info)

It certainly is working for me and others who are using revenue sharing with the 5.x-2.x version.

Check your apache error log for any messages there.

ElSanto’s picture

ElSanto commented

You need to activate modules: Adsense basic and Adsense revenue sharing basic, and configure too

mustafau’s picture

mustafau commented

AdSense core and API module makes a call to adsense_basic_adsense('status') on the settings page even if adsense_basic was not enabled.

kbahey’s picture

kbahey commented

Do you have a patch that I can review? See http://drupal.org/patch for how to create one.

mustafau’s picture

mustafau commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new adsense-no_id_choosing_module_fix.patch349 bytes

Attached.

kbahey’s picture

kbahey commented

Mustafa

The patch is not in unidiff format, but it is not a big issue since it is just a few lines.

I have committed it to the 5.x-2.x-dev tarball and it should be there by tomorrow.

I want people to test this change with the following scenarios:

1. only adsense_basic enabled.
2. only revenue_sharing_basic enabled.
3. Both revenue_sharing and adsense_basic enabled.
4. Both disabled.

See whether the error messages are consistent or not.

If this is confirmed to be working, I will make a stable release.

mustafau’s picture

mustafau commented

I confirmed that this patch works for;

1. only adsense_basic enabled.
4. Both disabled.

kbahey’s picture

kbahey commented
Status: Needs review » Fixed

Marking as fixed, since it is in the -dev tarball already.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.