Multiple annotations per uid + nid
Encarte - February 16, 2008 - 17:05
| Project: | Annotate |
| Version: | 6.x-1.x-dev |
| Component: | annotate (private) |
| Category: | bug report |
| Priority: | normal |
| Assigned: | clemens.tolboom |
| Status: | closed |
Description
Presently a user can make one annotation only. He can change the annotation, but he cannot make two different annotations. If multiple annotations were possible, an history of different annotations would be kept and a dialog between users (annotators) could be established. That way, annotation could work like an area to discuss an article or even to create a multi-author article without showing all the process to general public.
#1
This is why i'm developing annotate_bl. Please visit the demo site and leave a note on http://annotate.build2be.com/node/104/annotate_bl (login first) It's not finished yet but how is the UI?
Annotate (private) is for making private notes and share them with the author ... the 'others' was i guess a mistake. So i close this as a 'by design'
Regards,
Clemens.
#2
#3
How is the progress on the feature of highlighting text......
#4
I needed the same functionality (multiple annotations per uid+nid) and so I made a few minor changes to make this possible.
1) add timestamp to pkey of annotations table
2) add a couple of ORDER BY clauses to the SELECTs
3) get rid of the DELETE FROM {annotations} WHERE uid = %d and nid = %d prior to inserting an annotation, so we don't clobber them
4) added a lookup to get the profile NID for a user if it exists, and thereby show all the annotations FOR profile instead of BY a user
see attached patches
#5
I like the idea for multiple annotations but your patch
contains commented code:
+ //////////+ // let's NOT delete prior annotation(s) for uid+nid, so we can have multiple notes per uid+nid
+ // db_query("DELETE FROM {annotations} WHERE uid = %d and nid = %d", $user->uid, $nid);
refers to a node type:
+ $result = db_query("SELECT nid FROM {node} WHERE type = 'profile' AND uid = %d ORDER BY created DESC LIMIT 1", $account_uid);So I cannot use this patch :( Thanks for sharing though.
I'll try to create this myself now :)
This review is powered by Dreditor.
#6
Hmmm ... I need some input.
I can now input multiple (private) annotations but when having 10 annotations I have _10_ forms which is not so user friendly (maybe adding collapsible fieldsets with the first line in it would help?)
The timestamp is not the best ordering way so I was thinking to add the weight functionality to it.
And I guess we need a checkbox "allow multiple annotation" to stay compatible with the current version. On a per content type?
#7
I decided to stick with timestamp. When ordering annotations from multiple users weight is useless.
I have now checkboxes for multiple annotations per nodetype.
So only the layout of multiple annotations is still ugly ... I'll wrap a fieldset around multiple annotations which is then controlled by the admin setting 'show collapsed'. That will keep compatibility.
#8
Committed in dev version (cvs commit credits is incomplete ... sorry)
This new version should be compatible with the current release.
- Having more then 1 annotation shows extra fieldset
- The fieldset title of each annotation shows first 20 chars of note
#9
It is working but not flawless. The forms are above the node content :(
The form(s) are build piece by piece and then (incorrect) joined together.
A code review of 6.x-1.x-dev would be nice :)
#10
It's now a bug. I've done something the wrong way. Dunno what yet :(
It's about putting the _multiple_ forms wrapped with a fieldset into the node view.
#11
#222556 by Encarte, bdwelle, clemens.tolboom | DentalStudent: Fixed Multiple annotations per uid + nid.
A lot of changes but it should be compatible with the 6.x-1.0 version:
- collapsible multiple annotation
- new visibility for node annotators (for discussing not only with the editor)
- more theme function
#12
#13
Automatically closed -- issue fixed for 2 weeks with no activity.