Closed (fixed)
Project:
Annotate
Version:
6.x-1.x-dev
Component:
annotate (private)
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
16 Feb 2008 at 17:05 UTC
Updated:
2 Oct 2009 at 17:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
clemens.tolboomThis is why i'm developing annotate_bl. Please visit the demo site and leave a note on http://annotate.build2be.com/node/104/annotate_bl (login first) It's not finished yet but how is the UI?
Annotate (private) is for making private notes and share them with the author ... the 'others' was i guess a mistake. So i close this as a 'by design'
Regards,
Clemens.
Comment #2
clemens.tolboomComment #3
DentalStudent commentedHow is the progress on the feature of highlighting text......
Comment #4
bdwelle commentedI needed the same functionality (multiple annotations per uid+nid) and so I made a few minor changes to make this possible.
1) add timestamp to pkey of annotations table
2) add a couple of ORDER BY clauses to the SELECTs
3) get rid of the DELETE FROM {annotations} WHERE uid = %d and nid = %d prior to inserting an annotation, so we don't clobber them
4) added a lookup to get the profile NID for a user if it exists, and thereby show all the annotations FOR profile instead of BY a user
see attached patches
Comment #5
clemens.tolboomI like the idea for multiple annotations but your patch
contains commented code:
refers to a node type:
So I cannot use this patch :( Thanks for sharing though.
I'll try to create this myself now :)
This review is powered by Dreditor.
Comment #6
clemens.tolboomHmmm ... I need some input.
I can now input multiple (private) annotations but when having 10 annotations I have _10_ forms which is not so user friendly (maybe adding collapsible fieldsets with the first line in it would help?)
The timestamp is not the best ordering way so I was thinking to add the weight functionality to it.
And I guess we need a checkbox "allow multiple annotation" to stay compatible with the current version. On a per content type?
Comment #7
clemens.tolboomI decided to stick with timestamp. When ordering annotations from multiple users weight is useless.
I have now checkboxes for multiple annotations per nodetype.
So only the layout of multiple annotations is still ugly ... I'll wrap a fieldset around multiple annotations which is then controlled by the admin setting 'show collapsed'. That will keep compatibility.
Comment #8
clemens.tolboomCommitted in dev version (cvs commit credits is incomplete ... sorry)
This new version should be compatible with the current release.
- Having more then 1 annotation shows extra fieldset
- The fieldset title of each annotation shows first 20 chars of note
Comment #9
clemens.tolboomIt is working but not flawless. The forms are above the node content :(
The form(s) are build piece by piece and then (incorrect) joined together.
A code review of 6.x-1.x-dev would be nice :)
Comment #10
clemens.tolboomIt's now a bug. I've done something the wrong way. Dunno what yet :(
It's about putting the _multiple_ forms wrapped with a fieldset into the node view.
Comment #11
clemens.tolboom#222556 by Encarte, bdwelle, clemens.tolboom | DentalStudent: Fixed Multiple annotations per uid + nid.
A lot of changes but it should be compatible with the 6.x-1.0 version:
- collapsible multiple annotation
- new visibility for node annotators (for discussing not only with the editor)
- more theme function
Comment #12
clemens.tolboom