Port to drupal 6.0
reikiman - February 16, 2008 - 17:33
| Project: | IP to Country |
| Version: | HEAD |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | mrfelton |
| Status: | closed |
Jump to:
Description
I ran the coder (code review) module and it guided me to make some changes that got most of the way to having this function on drupal 6.
It still reports these issues:
ip2cc.module
severity: critical Line 240: new hook_theme() http://api.drupal.org/api/function/hook_theme/6 function is required to register theme_ functions (Drupal Docs http://drupal.org/node/114774#theme_registry)
function theme_ip2cc_flag($co, $addr = '') {
severity: critical Line 39: The menu system has been completely over-hauled in 6.x. (Drupal Docs http://drupal.org/node/102338)
if ($may_cache) {
severity: critical Line 40: The menu system has been completely over-hauled in 6.x. (Drupal Docs http://drupal.org/node/102338)
$items[] = array(
severity: critical Line 48: The menu system has been completely over-hauled in 6.x. (Drupal Docs http://drupal.org/node/102338)
$items[] = array(
severity: critical Line 58: The menu system has been completely over-hauled in 6.x. (Drupal Docs http://drupal.org/node/102338)
$items[] = array('path' => 'admin/settings/ip2cc/manage',
severity: critical Line 64: The menu system has been completely over-hauled in 6.x. (Drupal Docs http://drupal.org/node/102338)
$items[] = array('path' => 'admin/settings/ip2cc/update',
ip2cc.install
severity: critical click to read more Line 5: A new schema API has been added in 6.x (Drupal Docs http://drupal.org/node/146843)
switch ($GLOBALS['db_type']) {
Explanation: This patch caused changes to the format of hook_install(), hook_uninstall(), and hook_update_N(). No longer are switch statements done on $GLOBALS['db_type']; instead, use the variety of schema API functions to perform table manipulation.
severity: normal Line 57: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms
if ($fd = fopen(drupal_get_path('module','ip2cc').'/'.$filename, 'r')) {
severity: normal Line 57: missing space after comma
if ($fd = fopen(drupal_get_path('module','ip2cc').'/'.$filename, 'r')) {| Attachment | Size |
|---|---|
| ip2cc.diff | 5.25 KB |
#1
I plan to port this module in this week. Thanks!
#2
are you still alive, sugree? it is over a month since your planned week... ;-)
#3
Subscribing
#4
reikiman, sugree, et-al,
Was wondering if someone can provide an update as to where the porting stands.
Thanks in advance,
#5
I committed an initial Drupal 6 port last night. Please download and test the nightly snapshot and report any bugs as separate issues.
#6
Automatically closed -- issue fixed for two weeks with no activity.