Port to 6
reikiman - February 16, 2008 - 19:33
| Project: | Taxonomy Multi Editor |
| Version: | HEAD |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
Hmm, I didn't realize this had died. Anyway I ran coder (code review) and it guided for a few changes. There are still some issues as follows. Dunno if anybody will be there to pick this up.
Line 81: new hook_theme() function is required to register theme_ functions (Drupal Docs)
function theme_taxonomy_multi_edit_overview(&$form) {
severity: critical Line 17: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
if ($may_cache) {
severity: critical Line 18: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array('path' => 'admin/content/node/taxonomy_multi_edit', 'title' => t('assign categories'),
severity: critical Line 57: hook_form_alter() parameters have changed (Drupal Docs)
taxonomy_form_alter($fakeform, array(), $node->type .'_node_form');
severity: critical Line 130: hook_form_alter() parameters have changed (Drupal Docs)
taxonomy_multi_edit_content_form_alter($form, array(), $form_id);
severity: critical Line 156: $form['#submit'] and $form['#validate'] no longer support custom parameters
$form['#submit']['taxonomy_multi_edit_content_form_submit'] = array();
severity: critical Line 175: taxonomy_node_get_terms(), taxonomy_node_get_terms_by_vocabulary(), and taxonomy_node_delete() now take a full $node object, not just a nid (node id). (Drupal Docs)
$existing = taxonomy_node_get_terms($nid);| Attachment | Size |
|---|---|
| taxonomy_multi_edit.diff | 7.14 KB |
#1
I would also like to see this module get ported D6.
I didn't realize how much I depended on it until I started prepping a site to upgrade and kept using it to clean up some categories and nodes.
#2
Ok, stupid me, I didn't see your post and spent time to port it myself. Anyway I put my patch here, perhaps this will help in some ways.
I didn't know about "code review", any link ?
#3
http://drupal.org/project/coder
Though you may have found it by now :).
#4
Yes I did, but thank you for the idea, it is VERRRY useful !!
#5
my bad
somehow changed the title, putting it back
#6
Another request at http://drupal.org/node/298607 .
#7
subscribe
#8
The patches here didn't seem to solve the content admin 'node operations' selector (which was admittedly tricky), so I did a full rewrite for D6.
Release now up!
http://drupal.org/node/335758
#9
Menu titles and descriptions have internal translation
<?phpfunction taxonomy_multi_edit_menu() {
$items['admin/content/node/taxonomy_multi_edit'] = array(
- 'title' => t('Assign categories'),
+ 'title' => 'Assign categories',
'page callback' => 'drupal_get_form',
'page arguments' => array('taxonomy_multi_edit_overview'),
'access arguments' => array('administer nodes'),
'weight' => 5,
'type' => MENU_LOCAL_TASK
);
return $items;
}
?>
#10
Cool. Thanks for that.
This is what peer review is all about!
updated here
I also found a few inconsistancies by testing on another dev system and finally got a useful warning from PHP STRICT_NOTICES that revealed a genuine error!
First time ever! This makes it 0.005 useful instead of 0.000
(the DRUPAL-6--1-0 release was inadvertently deleting existing tags - which is pretty wrong)
#11
A stable version incorporating this may get tagged soon, after a few more demo tests. We need an updated screenshot etc
#12
Suppose better to make -dev - more people can test before release