Port to drupal 6.x
reikiman - February 16, 2008 - 21:33
| Project: | Taxonomy context |
| Version: | HEAD |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (code needs review) |
Description
I ran the coder (code review) module and it showed me some changes.
There are some remaining issues:
Line 432: new hook_theme() function is required to register theme_ functions (Drupal Docs)
function theme_taxonomy_context_subterms($terms) {
severity: criticalLine 40: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
if ($may_cache) {
severity: criticalLine 41: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
severity: criticalLine 49: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
severity: criticalLine 56: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
severity: normalLine 516: string concatenation should be formatted without a space separating the operators (dot .) and a quote
$where = 'WHERE tn.tid = %d ' .
taxonomy_context.install
severity: criticalclick to read moreLine 8: A new schema API has been added in 6.x (Drupal Docs)
switch ($GLOBALS['db_type']) {| Attachment | Size |
|---|---|
| taxonomy_context.diff | 9.58 KB |
#1
#2
Slightly better patch, including all the missing stuff from reikiman's. I haven't bothered with the cosmetic/coding standards changes either, just to keep the patch easier to review for the task in the issue title!
I was just starting to test this when I realised that Drupal 6 now supports the display of taxonomy/term descriptions by default (see this issue). This was the main reason I used the module, so I'm not sure how much more time I will commit to this. Of course, Drupal core still doesn't have the
/taxonomy/vocabulary/xpages or the context block provided here, so perhaps the module just needs a little rethinking.Hope this helps someone, anway.
#3
Thank you, it helped me. I am attaching the entire package for 6.1
#4
Would anyone be interested in creating/maintaining a D6 branch for taxonomy context? I am currently too swamped to add support for D6 right now.
Also, a version 2.0 of Taxonomy Context will hopefully be available soon. I would like to avoid having four branches of development (e.g. 5.x-1.x, 5.x-2.x, 6.x-1.x, 6.x-2.x) as I just don't have the time to support all of them (not to mention the joys of working with multiple CVS branches). So any thoughts or suggestions on this are much appreciated!
Version 2.0 will be adding a ton of features that I have found useful. I will be posting an official announcement soon that will describe the new features.
#5
I can probably test a 6.0 version of the module out, but I'm still learning the backend of Drupal, so I'm not comfortable with doing any major programming in it. However, I must say, I really do like the module and would hate to see it be only a version 5 one. It makes working with Drupal a lot easier! I wish I had discovered this module a lot earlier in my Drupal career, it would have saved me a bunch of headaches!
#6
Okay. I just released a dev of version 2. I think this is the version that I would like to see ported to Drupal 6, but I think it would be best to get any issues worked out with the the D-5 version before porting to D-6.
#7
Subscribing so I can help test.
Edit: The zipped version of Taxonomy Context in #3 actually works quite well on Drupal 6.2. I haven't received any errors or complaints so far. I was able to configure my Taxonomy block for a vocab and test it out. :-)
#8
Nice let me test as well :P
#9
subscribe.. and reviewing..