GetID3 documentation and installation help

ardas - February 16, 2008 - 23:08
Project:getID3()
Version:5.x-1.x-dev
Component:Code
Category:task
Priority:critical
Assigned:Unassigned
Status:needs work
Description

Greetings,

By default getid3 path is built from module path and one more '/getid3' folder.

function getid3_get_path() {
  return variable_get('getid3_path', drupal_get_path('module', 'getid3') .'/getid3');
}

When visiting settings page after enabling module it says getid3 lib is not found and the path is 'modules/getid3/getid3' which is correct.

Here is the reason - you are adding one more superfluous folder '/getid3/getid3.php':

function _getid3_admin_settings_check_path($form_element) {
  $path = $form_element['#value'];
  if (!is_dir($path) || !file_exists($path .'/getid3/getid3.php')) {
  ......

You probably have to change it to:

  ......
  if (!is_dir($path) || !file_exists($path .'/getid3.php')) {
  ......

#1

Rob Loach - February 17, 2008 - 09:47
Version:5.x-1.1» 5.x-1.x-dev
Status:active» needs review

Does this do it?

AttachmentSize
getid3.patch 1.18 KB

#2

guardian - February 26, 2008 - 16:38

not sure the patch works
i get no more error message, however i get this: Version GETID3_VERSION found.

#3

asb - April 17, 2008 - 01:25

Hi Rob,

same here; the patch applies cleanly, admin/settings/getid3 reports "Version GETID3_VERSION found" when saving the setting. The former error message ("The getID3 PHP library could not be found in modules/getid3/getid3") is gone, but the getid3 library still seems not to be found, at least according to the warning when a mediafield node is bing saved ("getid3 library not found!").

Greetings, -asb

#4

Rob Loach - May 7, 2008 - 18:13
Title:getid3 lib default path is wrong» GetID3 lib default path is wrong
Status:needs review» needs work

#5

drew reece - June 23, 2008 - 01:01

Bump,

Having the same trouble with the 5.x-1.1 version

Also seems to be a related issue here?
http://drupal.org/node/265969

Drew

#6

xjm - July 25, 2008 - 15:29
Status:needs work» needs review

The issue with mediafield not finding getid3 at a given path is an issue with mediafield, not with this module. Mediafield has a static requirement for the path and does not depend on or utilize this module. I'd submit that to the mediafield people.

Testing patch.

#7

xjm - July 25, 2008 - 15:48

I applied the patch and set my custom path to misc/lib/getid3/ (which is the location required by mediafield). This resolved the issue for me. I'd recommend those trying to use both mediafield and modules that depend on this one try that and re-test the patch.

To use both mediafield and modules that depend on this one:

  1. Apply the patch: http://drupal.org/files/issues/getid3.patch.
  2. Put the whole getid3 library in drupalroot/misc/lib/getid3/ (there will be misc/lib/getid3/getid3 inside this directory among other things; don't let that confuse you).
  3. At admin/settings/getid3, set the path to misc/lib/getid3/ and save.

#8

xjm - July 25, 2008 - 16:03

Whoops, sorry for changing your status; didn't realize you were the maintainer.

I do think the patch is OK, though. :P The only concern might be that the constant GETID3_VERSION wasn't interpreted properly for asb. It does work alright for me; I get Version 1.7.7 found.

#9

jmcclelland - October 30, 2008 - 15:56

Thanks for the patch. It works for me against version 5. I also get the correct version reported (Version 1.7.7).

#10

jmcclelland - October 30, 2008 - 16:02

I'm adding a revised patch. The original patch doesn't fix the Drupal status report file path check.

AttachmentSize
getid3.2008.10.30.patch 1.61 KB

#11

drewish - October 30, 2008 - 17:32
Status:needs review» needs work

patch doesn't apply to DRUPAL-5

#12

nextgate - November 24, 2008 - 13:46

Is there a patch for DRUPAL-5 ? I need this one :(

#13

markus_petrux - November 30, 2008 - 19:58

sorry, nevermind

#14

whiteowl - December 14, 2008 - 07:28

After the issues with Mediafield are subtracted. I don't think this can be reliably solved without corresponding documentation about where to put the getid3 project files. I have documented one way to do this at #297258: Documentation is needed following the convention from the Audio module.

This does not correspond to the patch from jmcclelland in response #10.

No patch is needed with getid3 1.7.7 and getid3 6.x-1.x-dev and the procedure in node 297258 comment #7.

#15

jamyers2k - February 16, 2009 - 17:17

The problem for me is that there is no sub folder named 'lib' in 'misc' for some reason.

#16

drew reece - February 16, 2009 - 19:00

@ jamyers2k,

You need to create the lib folder inside misc & put getid3 library inside it. It is not a location that exists in Drupal by default.

#17

jamyers2k - March 6, 2009 - 00:58

Got it working. Many thanks.

#18

IanMerwin - June 28, 2009 - 17:19

I ran into this today... maybe this will help (my install instructions )drupal.org/node/371920#comment-1752374
The problem I had was when installing the module and the accompanying library - if one is not careful - the module will not find the library. It (by default is looking for /getid3/getid3/getid3)

Which bugged me so I tried to clean it up and get rid of at least one sub-directory by moving the files up one dir. - But, it would not find the library... it has to be "/getid3/getid3/getid3"

Hope this helps...

#19

micah - September 2, 2009 - 18:09

I just installed this in 6.x, using getid3-1.7.9 for the first time. The problem that older versions of getid3 (namely 1.7.7) had a directory structure in the zip file, but 1.7.9 ships everything flat. The extra /getid3 subdirectory was necessary with the older version of the getid3 library, but now it is not.

#20

drewish - November 26, 2009 - 01:06
Title:GetID3 lib default path is wrong» GetID3 lib default path is wrong / backport fixes from HEAD

working on this and some other fixes.

AttachmentSize
getid3_222666.patch 8.83 KB

#21

Rob Loach - November 26, 2009 - 18:58
Title:GetID3 lib default path is wrong / backport fixes from HEAD» GetID3 documentation and installation help
Category:bug report» task
Priority:normal» critical

Very nice! Pushing to critical so it's more prominent on the issue radar.

 
 

Drupal is a registered trademark of Dries Buytaert.