Trailing space check should check for blank lines as well

Ah, I figured this had to be trim()ed somewhere, because changing that rule didn't seem to affect anything.

As to whether or not to remove that optimization, hm. That's a good question.

The extra whitespace certainly doesn't hurt anything; it just looks kinda sloppy. However, certain editors (Zend, for one) are smart enough to strip out trailing whitespace on these types of lines, and will do it for you automatically, leading to "noise" in patches from people using those editors. These lines are also basically impossible for the "human eye" to spot these things, and seems like a perfect opportunity for a computer to do your checking for you. :)

I guess given that, I would be in favour of removing the optimization... or, rather, leaving it in only for lines that are just \n and nothing else; no sense in running all of those rules on the plain newline between one function and another, for example.

Here's a patch that does the above.

It looks like this whole section could be simplified by storing the various types of lines in an array or something and just iterating through them. Currently, it looks like there are quite a few lines that need to be added if we ever decided to add a new type of line in the future. But I've kept this patch simple for now.

Oops, sorry. That had the menu link fix in there accidentally.

I did test this patch, but not on Windows (I'm on OS X). That's a good question, though. Hrm... not sure how to deal with that.

I went into Smulton and saved it as "Dark Side" line endings ;) and confirmed that this definitely doesn't strip those out. Will keep futzing.