no icons

After installing FileField 5.x-2.3-rc2, creating an ico directory and uploading several __.png files I still didn't see any icons.

Looking into the code of filefield.module (716-721) I found:

  $icon = '';
  $iconpath = base_path() .'/'. drupal_get_path('module','filefield') .'/ico/'. $ext .'.png';
  if (file_exists($iconpath)) {
    $icon = '<img class="field-icon-'. $ext .'" src="'. $imagepath .'" />';
  }
  return '<div class="filefield-icon field-icon-'. $ext .'">'. $icon .'</div>';

The trouble seems to be that $imagepath isn't defined (it seems to be $iconpath), there is a .'/'. too many and the "file_exists" can be problematic on a safe_mode PHP install.

I could make the icons work again by replacing the code above by the following:

  $icon = '';
  $iconpath = base_path() . drupal_get_path('module','filefield') .'/ico/'. $ext .'.png';
  if (!$size=@getimagesize($iconpath)) {
    $icon = '<img class="field-icon-'. $ext .'" src="'. $iconpath .'" />';
  }
  return '<div class="filefield-icon field-icon-'. $ext .'">'. $icon .'</div>';

In order be able to see the icons I also had to remove the div.filefield-icon definition from the filefield.css.

Now the icons are visible again while editing nodes and pasting the code from #196957: Add icons to default filefield formatters. into your template.php will make the icons show up while viewing nodes as well.