Fivestar doesn't work properly with Thickbox in Firefox

I can't access your test site. Do you have another place to have a look or additional information that might help lead to the problem?

Neat site. I unfortunately couldn't reproduce with Firefox 2.0.0.12 (Mac OS X). What version of Firefox are you using (any plugins also)? Do you get javascript errors on the page?

Itay,

It seems fivestar doesn't completely work in a thickbox. But do other pages, that use javascript, work in a thickbox?

In other words:

Open, e.g., 'node/add/whatever' in a thickbox and see if you can open/close the collapsed fieldsets in it (in Firefox).

Closing after lack of activity.

Yes, this issue should be closed.

But I'm marking it "won't fix" instead.

I was able to reproduce the problem on my computer. There are actually several JS problems here, but after some investigation I concluded that these problems have little to do with Fivestar itself (These problems could be seen with almost any other page that uses jQuery) .

But there is actually one JS problem, not reported in this issue, that is indeed Fivestar's fault. I opened an offshoot issue to address it: #246804: javascript: 'class guard' + behavior

I found a fix for this, it involves modifying thickbox itself so that, instead of dropping the html inside the thickbox, it appends it, which keeps the various initializations (particularly the event handlers) that fivestar does.

I'll submit the patch to Cody Lindley the Thickbox developper, but in the meantime here is what I've done (which might not work if there's just plaintext inside the div with the inlineId class) :

in modules/thickbox/thickbox.js

line 211 replace

$("#TB_ajaxContent").html($('#' + params['inlineId']).html());

by

$("#TB_ajaxContent").append($('#' + params['inlineId']).children().attr("inlineId",params['inlineId']));

and then line 261 (after $("#TB_closeWindowButton").unbind("click");) add the following :

inlineId = $("#TB_ajaxContent").children().attr("inlineId");
$("#TB_ajaxContent").children().removeAttr("inlineId");
$('#' + inlineId).append($("#TB_ajaxContent").children());

I'll post about this fix in the thickbox issues as well.

Hope this helps,

Jun.