The [node-type] token references the "machine" name for node type, instead of the "human" readable one.

Drupal doesn't allow the "machine" name of a node type to be changed once it is set. But users can modify the "human" node type field. They also have greater freedom with this field -- for example, users can only use spaces in this field.

Using the default settings for the Activity module, this message might be generated in the block:
"JohnSmith updated the forum Hello World"

Wouldn't it be better to reference the more intuitive "human" node title field?
"JohnSmith updated the forum topic Hello World"

CommentFileSizeAuthor
#1 nodeactivity-223021-0.patch576 bytesneopoet

Comments

neopoet’s picture

neopoet commented
Status: Active » Needs review
StatusFileSize
new nodeactivity-223021-0.patch576 bytes
WISEOZ’s picture

WISEOZ commented

I applied this patch and ran update.php as well but I don't see any change. The [node-type] token still references the "machine" name.

jaydub’s picture

jaydub commented

The patch worked for me. I tested by setting a 'human' name to the story content type, added a story node and the activity line showed up with the 'human' name....

neopoet’s picture

neopoet commented

WISEOZ,

Thanks for testing the patch.

You'll only see the change in your activity feed AFTER a new activity triggers the module. IE:

1. JohnSmith posts a new forum thread.
2. You see the message "JohnSmith updated the forum Hello World"
3. You apply the patch.
4. JohnSmith posts a second new forum thread.
5. You'll see the new activity "line" under the old one ("JohnSmith updated the forum topic Hello World"). But the old line will stay up there until new lines push it away (that's just how the underlying module works).

Andrew

WISEOZ’s picture

WISEOZ commented

Thanks! I'll keep this in mind.

sirkitree’s picture

sirkitree commented
Status: Needs review » Fixed

Thanks, made this change.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.