No one was using these anyway :)

Comments

cwgordon7’s picture

Status: Active » Needs work

This does not deal with using existing filters as flexifilter components. Invoking hook_filter with ($op = 'run') will do nothing.

dmitrig01’s picture

StatusFileSize
new29.75 KB
cwgordon7’s picture

This still does not deal with the previously mentioned problem.

To be specific, this line:

<?php
$text = module_invoke($module, 'filter', $op, $delta, 1, $text);
?>

Will flop, as op will be 'run', now, not 'prepare' or 'process'.

cwgordon7’s picture

(But for the record, I think that this is a good idea, just needs some minor tweaking)

corsix’s picture

As long as we want full compatibility with the existing filter system, we cannot remove step.
I define compatibility as: Using a filter in an input format will have the same effect as using the filter as the sole component in a flexifilter and using the flexifilter in an input format.
To do this, the flexifilter needs to receive and dispatch two steps, not one.

cwgordon7’s picture

I disagree. It is possible to do in one step by invoking both hook_filter ops in the flexifilter component's run op. What would be wrong with this?

corsix’s picture

A,B,C are normal filters, things happen in this order:
A prepare
B prepare
C prepare
A process
B process
C process

B is replaced by a flexifilter containing the filter as a component, things now happen in a different order if flexifilters only have one step:
A prepare
C prepare
A process
B prepare
B process
C process

cwgordon7’s picture

Status: Needs work » Postponed

I see what you are saying. Thus am marking postponed until we can change core hook_filter.