The "Use block visibility settings (see block config)" checkbox doesn't do anything because of a misnamed variable

CommentFileSizeAuthor
#3 panels2-block_visibility.patch1.05 KBjohn morahan
#2 panels2-block_visibility.patch994 bytesjohn morahan
panels2-block_visibility.patch888 bytesjohn morahan

Comments

john morahan’s picture

john morahan commented
Status: Active » Needs review
john morahan’s picture

john morahan commented
StatusFileSize
new panels2-block_visibility.patch994 bytes

Make that two misnamed variables

john morahan’s picture

john morahan commented
StatusFileSize
new panels2-block_visibility.patch1.05 KB

Three, even

softtouch’s picture

softtouch commented

Some user might not be able to use patch (like me), is it possible to attach a patched version?

merlinofchaos’s picture

merlinofchaos commented

Sorry, the issue queue isn't primarily a tool to get patches to users, it's primarily a tool to fix issues in the code that is hosted on the site. Attaching full versions of code will detract from that purpose, and annoy me greatly.

meba’s picture

meba commented
Status: Needs review » Needs work

I can't confirm this patch works (or works different way).

I created a panel, added a block to it. Then I viewed it - block is displayed. Panel URL is "test". Then I edited the block and made it "Display only on listed pages" with "foobar" as an URL.

Note that "test" != "foobar".

Now the block is still visible on panel page.

john morahan’s picture

john morahan commented
Status: Needs work » Needs review

You don't mention that you checked the "Use block visibility settings (see block config)" checkbox - perhaps you forgot that step?

I repeated the process you described but with the checkbox checked, and it seemed to work for me.

sdboyer’s picture

sdboyer commented

Nice catch, John. Code looks good, debugging through it looks good, and I've reproduced the intended effect in my sandbox. Changes have been committed for beta3. Thanks!

sdboyer’s picture

sdboyer commented
Status: Needs review » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.